Deprecate AtomicCell::get_mut #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 22, 2019
332: Deprecate AtomicCell::get_mut r=stjepang a=stjepang This is an essential step in solving #315 - there is no way to make `AtomicCell::get_mut()` sound, unfortunately. Let's deprecate it and remove in the next release. Co-authored-by: Stjepan Glavina <[email protected]>
Build succeeded |
ghost
deleted the
jeehoonkang
added a commit
to jeehoonkang/crossbeam
that referenced
this pull request
May 10, 2019
PR crossbeam-rs#332 deprecated after the discussion of issue crossbeam-rs#315, but it is a measure not yet necessary to take. Revert the deprecation and wait for us to reach a consensus.
jeehoonkang
added a commit
to jeehoonkang/crossbeam
that referenced
this pull request
May 11, 2019
PR crossbeam-rs#332 deprecated after the discussion of issue crossbeam-rs#315, but it is a measure not yet necessary to take. Revert the deprecation and wait for us to reach a consensus.
jeehoonkang
added a commit
to jeehoonkang/crossbeam
that referenced
this pull request
May 11, 2019
PR crossbeam-rs#332 deprecated after the discussion of issue crossbeam-rs#315, but it is a measure not yet necessary to take. Revert the deprecation and wait for us to reach a consensus.
ghost
mentioned this pull request
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an essential step in solving #315 - there is no way to make
AtomicCell::get_mut()sound, unfortunately. Let's deprecate it and remove in the next release.