Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating dependencies #2091

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Updating dependencies #2091

wants to merge 3 commits into from

Conversation

oberstet
Copy link
Contributor

@oberstet oberstet commented Aug 23, 2023 •
edited
Loading

No description provided.

@oberstet oberstet mentioned this pull request Aug 23, 2023
Closed
@oberstet
Copy link
Contributor Author

unfortunately, the CI is broken (well, not running at all) because of #2092

Bastian-Krause added a commit to Bastian-Krause/crossbar that referenced this pull request Aug 24, 2023
@Bastian-Krause
common/reloader: import reload from importlib
b02f5c8 
The imp module is deprecated since Python 3.4 [1]. The import was added
even after it was deprecated in [2]. In Python 3.12 the imp module will
be removed.

Use the reload function from importlib, which is the designated
replacement [1].

With crossbario#2091 and this change, crossbar can be installed and run on
Python 3.12 with:
- numpy>=1.26.0b1
- wsaccel @ git+https://github.com/methane/[email protected] (assuming
  cython>=3.0.0 is installed, tarball from pypi won't work [3])

[1] https://docs.python.org/3.11/library/imp.html
[2] crossbario@21910b0
[3] methane/wsaccel#30
@Bastian-Krause Bastian-Krause mentioned this pull request Aug 24, 2023
Merged
oberstet pushed a commit that referenced this pull request Aug 24, 2023
@Bastian-Krause
common/reloader: import reload from importlib (#2093)
0089c1e 
The imp module is deprecated since Python 3.4 [1]. The import was added
even after it was deprecated in [2]. In Python 3.12 the imp module will
be removed.

Use the reload function from importlib, which is the designated
replacement [1].

With #2091 and this change, crossbar can be installed and run on
Python 3.12 with:
- numpy>=1.26.0b1
- wsaccel @ git+https://github.com/methane/[email protected] (assuming
  cython>=3.0.0 is installed, tarball from pypi won't work [3])

[1] https://docs.python.org/3.11/library/imp.html
[2] 21910b0
[3] methane/wsaccel#30
@Bastian-Krause Bastian-Krause mentioned this pull request Aug 24, 2023
Closed
9 tasks
@DZabavchik DZabavchik mentioned this pull request Sep 1, 2023
Open
@Bastian-Krause
Copy link
Contributor

As predicted in #2093: With wsaccel 0.6.6, numpy 1.26.0 and aiohttp 3.9.0 being released, this PR is the last thing needed for crossbar Python 3.12 compatibility. Any chance to get this merged soon?

By the way, I need to specify eth-utils<2.3.0 to make crossbar work (unrelated to Python 3.12) . Otherwise I see:

  Traceback (most recent call last):
    File "/home/runner/work/labgrid/labgrid/crossbar-venv/bin/crossbar", line 5, in <module>
      from crossbar import run
    File "/home/runner/work/labgrid/labgrid/crossbar-venv/lib/python3.12/site-packages/crossbar/__init__.py", line 19, in <module>
      import eth_abi
    File "/home/runner/work/labgrid/labgrid/crossbar-venv/lib/python3.12/site-packages/eth_abi/__init__.py", line 15, in <module>
      from eth_abi.abi import (  # NOQA
    File "/home/runner/work/labgrid/labgrid/crossbar-venv/lib/python3.12/site-packages/eth_abi/abi.py", line 1, in <module>
      from eth_abi.codec import (
    File "/home/runner/work/labgrid/labgrid/crossbar-venv/lib/python3.12/site-packages/eth_abi/codec.py", line 12, in <module>
      from eth_abi.decoding import (
    File "/home/runner/work/labgrid/labgrid/crossbar-venv/lib/python3.12/site-packages/eth_abi/decoding.py", line 8, in <module>
      from eth_utils import (
    File "/home/runner/work/labgrid/labgrid/crossbar-venv/lib/python3.12/site-packages/eth_utils/__init__.py", line 86, in <module>
      from .network import (
    File "/home/runner/work/labgrid/labgrid/crossbar-venv/lib/python3.12/site-packages/eth_utils/network.py", line 7, in <module>
      from eth_typing import ChainId
  ImportError: cannot import name 'ChainId' from 'eth_typing' (/home/runner/work/labgrid/labgrid/crossbar-venv/lib/python3.12/site-packages/eth_typing/__init__.py)

@Bastian-Krause
Copy link
Contributor

Ping?

@oberstet
Copy link
Contributor Author

oberstet commented Dec 11, 2023 •
edited
Loading

@Bastian-Krause yeah, fair enough, it should really be fixed. I mean the CI overall, and this specifically as well. personally, I won't have time soon, as my focus is on stuff that earns me money, sorry! classical OSS destiny;) if commercial users (and I'm not talking about you or your org) are using it (I know for a fact of publicly listed companies that do), they should pay for support and community, or provide fixes / PRs, or use something else. it's a free world .. pun;)

side note: btw, I did apply at https://www.sovereigntechfund.de/, which first moved on, but then failed as I am apparently better at code than forms, and I am not inclined to waste a life on burocracy;) anyways, just saying.

Bastian-Krause pushed a commit to Bastian-Krause/labgrid that referenced this pull request Dec 13, 2023
@basti2342
tests/test_crossbar: mark tests incompatible with python3.12+
3908c4e 
crossbar is not compatible with Python 3.12, yet: [1] and [2] are not
part of a release. A release will probably take some more time [3][4].

Since this is the last remaining issue before we can advertise Python
3.12 support, let's mark these tests as XFAIL for now.

[1] crossbario/crossbar#2091
[2] crossbario/crossbar#2093
[3] crossbario/crossbar#2093 (comment)
[4] crossbario/crossbar#2091 (comment)

Signed-off-by: Bastian Krause <[email protected]>
Bastian-Krause added a commit to Bastian-Krause/labgrid that referenced this pull request Dec 13, 2023
@Bastian-Krause @basti2342
github/workflows: test Python 3.12
92b7cd5 
crossbar is not compatible with Python 3.12, yet: [1] and [2] are not
part of a release. A release will probably take some more time [3][4].

We shouldn't advertise Python 3.12 support until that happens. But we
can make sure that everything else keeps working fine with Python 3.12
by running the test suite. A previous commit marked the failing crossbar
tests as XFAIL for 3.12.

[1] crossbario/crossbar#2091
[2] crossbario/crossbar#2093
[3] crossbario/crossbar#2093 (comment)
[4] crossbario/crossbar#2091 (comment)

Signed-off-by: Bastian Krause <[email protected]>
Bastian-Krause added a commit to Bastian-Krause/labgrid that referenced this pull request Dec 13, 2023
@Bastian-Krause
tests/test_crossbar: mark tests incompatible with python3.12+
43ed218 
crossbar is not compatible with Python 3.12, yet: [1] and [2] are not
part of a release. A release will probably take some more time [3][4].

Since this is the last remaining issue before we can advertise Python
3.12 support, let's mark these tests as XFAIL for now.

[1] crossbario/crossbar#2091
[2] crossbario/crossbar#2093
[3] crossbario/crossbar#2093 (comment)
[4] crossbario/crossbar#2091 (comment)

Signed-off-by: Bastian Krause <[email protected]>
Bastian-Krause added a commit to Bastian-Krause/labgrid that referenced this pull request Dec 13, 2023
@Bastian-Krause
github/workflows: test Python 3.12
9eea1cc 
crossbar is not compatible with Python 3.12, yet: [1] and [2] are not
part of a release. A release will probably take some more time [3][4].

We shouldn't advertise Python 3.12 support until that happens. But we
can make sure that everything else keeps working fine with Python 3.12
by running the test suite. A previous commit marked the failing crossbar
tests as XFAIL for 3.12.

[1] crossbario/crossbar#2091
[2] crossbario/crossbar#2093
[3] crossbario/crossbar#2093 (comment)
[4] crossbario/crossbar#2091 (comment)

Signed-off-by: Bastian Krause <[email protected]>
@Bastian-Krause Bastian-Krause mentioned this pull request Dec 13, 2023
Merged
1 task
Bastian-Krause added a commit to Bastian-Krause/labgrid that referenced this pull request Dec 13, 2023
@Bastian-Krause
tests/test_crossbar: mark tests incompatible with python3.12+
ccbccf3 
crossbar is not compatible with Python 3.12, yet: [1] and [2] are not
part of a release. A release will probably take some more time [3][4].

Since this is the last remaining issue before we can advertise Python
3.12 support, let's mark these tests as XFAIL for now.

[1] crossbario/crossbar#2091
[2] crossbario/crossbar#2093
[3] crossbario/crossbar#2093 (comment)
[4] crossbario/crossbar#2091 (comment)

Signed-off-by: Bastian Krause <[email protected]>
Bastian-Krause added a commit to Bastian-Krause/labgrid that referenced this pull request Dec 13, 2023
@Bastian-Krause
github/workflows: test Python 3.12
4f23236 
crossbar is not compatible with Python 3.12, yet: [1] and [2] are not
part of a release. A release will probably take some more time [3][4].

We shouldn't advertise Python 3.12 support until that happens. But we
can make sure that everything else keeps working fine with Python 3.12
by running the test suite. A previous commit marked the failing crossbar
tests as XFAIL for 3.12.

[1] crossbario/crossbar#2091
[2] crossbario/crossbar#2093
[3] crossbario/crossbar#2093 (comment)
[4] crossbario/crossbar#2091 (comment)

Signed-off-by: Bastian Krause <[email protected]>
@ninousf ninousf mentioned this pull request Jun 1, 2024
Closed
@Skully17 Skully17 mentioned this pull request Jul 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oberstet @Bastian-Krause