Pass cargo configuration flags to docker. #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Setting |
|
This is ready for review. The only envvars that might not work are the proxy ones, but it's better to fail hard with these than accept inaccurate configurations. |
Emilgardis
approved these changes
Jun 26, 2022
Ensures the following flags are passed to docker: - BROWSER - CARGO_BUILD_DEP_INFO_BASEDIR - CARGO_BUILD_INCREMENTAL - CARGO_BUILD_JOBS - CARGO_BUILD_RUSTDOCFLAGS - CARGO_BUILD_RUSTFLAGS - CARGO_CACHE_RUSTC_INFO - CARGO_CACHE_RUSTC_INFO - CARGO_FUTURE_INCOMPAT_REPORT_FREQUENCY - CARGO_HTTP_CAINFO - CARGO_HTTP_CHECK_REVOKE - CARGO_HTTP_DEBUG - CARGO_HTTP_LOW_SPEED_LIMIT - CARGO_HTTP_MULTIPLEXING - CARGO_HTTP_PROXY - CARGO_HTTP_SSL_VERSION - CARGO_HTTP_TIMEOUT - CARGO_HTTP_USER_AGENT - CARGO_INCREMENTAL - CARGO_INCREMENTAL - CARGO_NET_GIT_FETCH_WITH_CLI - CARGO_NET_OFFLINE - CARGO_NET_RETRY - HTTP_TIMEOUT - HTTPS_PROXY - RUSTDOCFLAGS - RUSTFLAGS - TERM These are always correct, since these configure how `cargo` behavior is supposed to work, but don't rely on any paths on the host filesystem. We also have some future-proofing, since we accept anything starting with `CARGO_` except the following variables: It also ensures the following overridden environment variables are not passed: - CARGO_HOME - CARGO_TARGET_DIR - CARGO_BUILD_TARGET_DIR And it ensures the following not-yet-supported environment variables are not passed: - CARGO_BUILD_RUSTC - CARGO_BUILD_RUSTC_WRAPPER - CARGO_BUILD_RUSTC_WORKSPACE_WRAPPER - CARGO_BUILD_RUSTDOC
|
bors r=Emilgardis |
|
Build succeeded: |
This was referenced Jul 2, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass cargo configuration flags to docker.
Ensures the following flags are passed to docker:
These are always correct, since these configure how
cargobehavior issupposed to work, but don't rely on any paths on the host filesystem. We also have some future-proofing, since we accept anything starting with
CARGO_except the following variables:It also ensures the following overridden environment variables are not passed:
And it ensures the following not-yet-supported environment variables are not passed: