Fix build issues #206

malbarbo · 2018-07-02T22:51:25Z

This fixes almost all current build issues. Only two issues are left:

thumb* tests, which requires using https://github.com/japaric/utest instead of https://github.com/japaric/cortest
netbsd build, which is failing with libc linking issues

malbarbo · 2018-07-02T22:53:56Z

I think the remaining issues can be fixed later (or the support for the affect targets be removed).

Merging this PR will allows many of the queued PR to be tested and merged, so I think it is the away to go.

Bobo1239 · 2018-09-19T09:21:57Z

Just as a heads up: currently there are 7 failing targets with this PR (after one small patch for xargo). Fortunately only two underlying issues are causing this:

During compilation of libgit2 (for cargo):

cargo:warning=libgit2/src/iterator.c: In function 'filesystem_iterator_set_current':
cargo:warning=libgit2/src/iterator.c:1464:43: error: 'struct stat' has no member named 'st_ctim'
cargo:warning=  iter->entry.ctime.nanoseconds = entry->st.st_ctime_nsec;
cargo:warning=                                           ^
cargo:warning=libgit2/src/iterator.c:1465:43: error: 'struct stat' has no member named 'st_mtim'
cargo:warning=  iter->entry.mtime.nanoseconds = entry->st.st_mtime_nsec;
cargo:warning=

During compilation of zlib (for cargo):

running: "sparcv9-sun-solaris2.10-gcc" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "-I" "src/zlib" "-fvisibility=hidden" "-DSTDC" "-D_LARGEFILE64_SOURCE" "-D_POSIX_SOURCE" "-o" "/target/sparcv9-sun-solaris/debug/build/libz-sys-ae25cc32c0bf34bd/out/build/src/zlib/adler32.o" "-c" "src/zlib/adler32.c"
cargo:warning=In file included from /usr/local/sparcv9-sun-solaris2.10/usr/include/limits.h:38:0
cargo:warning=                 from /usr/local/lib/gcc/sparcv9-sun-solaris2.10/5.3.0/include-fixed/limits.h:168
cargo:warning=                 from /usr/local/lib/gcc/sparcv9-sun-solaris2.10/5.3.0/include-fixed/syslimits.h:7
cargo:warning=                 from /usr/local/lib/gcc/sparcv9-sun-solaris2.10/5.3.0/include-fixed/limits.h:34
cargo:warning=                 from src/zlib/zconf.h:418
cargo:warning=                 from src/zlib/zlib.h:34
cargo:warning=                 from src/zlib/zutil.h:22
cargo:warning=                 from src/zlib/adler32.c:8:
cargo:warning=/usr/local/lib/gcc/sparcv9-sun-solaris2.10/5.3.0/include-fixed/sys/feature_tests.h:408:2: error: #error "Compiler or options invalid for pre-UNIX 03 X/Open applications 	and pre-2001 POSIX applications"
cargo:warning= #error "Compiler or options invalid for pre-UNIX 03 X/Open applications \
cargo:warning=  ^

Does somebody know how one could fix these?

bgermann · 2018-09-20T19:23:29Z

I have fixed upstream:

Bobo1239 · 2018-09-23T22:49:27Z

https://travis-ci.org/Bobo1239/cross/builds/432241101
Down to two failures which now end with:

cargo:warning=libgit2/src/sysdir.c: In function 'get_passwd_home':
cargo:warning=libgit2/src/sysdir.c:55:11: error: too many arguments to function 'getpwuid_r'
cargo:warning=   error = getpwuid_r(uid, &pwd, buf, buflen, &pwdptr);
cargo:warning=           ^
cargo:warning=In file included from libgit2/src/sysdir.c:18:0:
cargo:warning=/usr/local/sparcv9-sun-solaris2.10/usr/include/pwd.h:166:23: note: declared here
cargo:warning= extern struct passwd *getpwuid_r(uid_t, struct passwd *, char *, int);
cargo:warning=                       ^
cargo:warning=libgit2/src/sysdir.c:55:9: warning: assignment makes integer from pointer without a cast [-Wint-conversion]
cargo:warning=   error = getpwuid_r(uid, &pwd, buf, buflen, &pwdptr);
cargo:warning=         ^

@bgermann I believe this should've been fixed by rust-lang/cmake-rs#45 (also see Bobo1239@6b5266b) and iirc this error did disappear back then. Any clue why it's resurfacing now?

bgermann · 2018-09-24T23:25:24Z

alexcrichton/git2-rs@76f4b74 is the cause for the new failures.

Fix: https://github.com/alexcrichton/git2-rs/pull/356

Bobo1239 · 2018-09-25T19:12:54Z

https://travis-ci.org/Bobo1239/cross/builds/433072223 Everything's green now 🍾 (even x86_64-unknown-netbsd works) My branch only merged master and added two small commits.
Thanks @malbarbo and @bgermann for your efforts!
@malbarbo Can you add the two changes to this PR?
@Dylan-DPC @japaric Can we look into merging this after that?

bgermann · 2018-09-27T14:40:39Z

What needs to be done to get this merged?

Dylan-DPC-zz · 2018-09-27T15:10:46Z

@bgermann would like @japaric or someone from rust-embedded team to review this as well. Waiting on that 👍

ryankurte · 2018-09-27T23:32:24Z

bors try

(I can't remember if bors is setup for this project, will try a local build later on if not)

Bobo1239 · 2018-09-27T23:51:54Z

Do note that two (or atleast the first) commits have to be added before everything's green:

ryankurte · 2018-09-28T00:32:45Z

Ahh, thanks! Is there any reason not to apply those over this PR so everything is green?
(Cc. @malbarbo or I can do it)

bors · 2018-09-28T01:46:31Z

try

Build failed

continuous-integration/travis-ci/push

…xed upstream)

Dylan-DPC-zz · 2018-09-29T12:00:16Z

@Bobo1239 possible but previous builds have worked fine. I think it is better to reduce the verbosity of the build first

bors · 2018-09-29T12:04:16Z

Build failed

continuous-integration/travis-ci/push

Bobo1239 · 2018-09-29T12:26:35Z

@Dylan-DPC Can you specify which previous builds you are referring to? It appears to me that previous builds were genuinely failing and before that (10 months ago) @japaric had the same issue. The last two green builds only became green after @ryankurte manually restarted the failing jobs. (Though the "bors try" run seems to have succeeded immediately.)

Regardless of that, reducing the verbosity of the build should be as easy as removing this line in ci/script.sh. @malbarbo Can you add a commit which does this and let @Dylan-DPC start a new run?

Dylan-DPC-zz · 2018-09-29T15:08:33Z

@Bobo1239 my bad. was probably thinking of some other repo. Yeah bors will fail even if we manually restart the builds on travis because it creates a new build.

With regards to the travis thing, i think it is better to do it in a separate PR. will do that change right now.

213: remove export to make CI process less verbose r=ryankurte a=Dylan-DPC The bors builds are failing probably because of the verbosity of the build. Removing this as per [this comment](#206 (comment)) Co-authored-by: Dylan DPC <[email protected]>

malbarbo · 2018-10-04T18:08:55Z

@Dylan-DPC and @ryankurte I've added the python workaround. Please consider this pragmatic solution so we can move this forward.

Dylan-DPC-zz · 2018-10-04T18:10:08Z

@malbarbo thanks. The problem is we might not be able to merge it because it may still use the old configuration (at least on bors).

ryankurte · 2018-10-04T21:34:52Z

Thanks for that @Dylan-DPC, I guess we'll need to remove it when #213 lands.

bors retry

206: Fix build issues r=Dylan-DPC a=malbarbo This fixes almost all current build issues. Only two issues are left: - thumb* tests, which requires using https://github.com/japaric/utest instead of https://github.com/japaric/cortest - netbsd build, which is failing with libc linking issues Co-authored-by: Marco A L Barbosa <[email protected]>

Bobo1239 · 2018-10-04T22:59:24Z

Seems to have worked :D Unfortunately this run has another spurious issue:

fatal: unable to access 'https://github.com/rust-lang-nursery/compiler-builtins/': Could not resolve host: github.com

but I think this was just bad luck. Guess we'll need another run...

Dylan-DPC-zz · 2018-10-04T23:00:54Z

Yeah it is just a network error

bors · 2018-10-04T23:04:25Z

Build failed

continuous-integration/travis-ci/push

Bobo1239 · 2018-10-05T16:09:48Z

@Dylan-DPC @ryankurte Can one of you start a (hopefully last) new run?

Dylan-DPC-zz · 2018-10-05T16:37:08Z

bors retry

Dylan-DPC-zz · 2018-10-05T16:42:18Z

bors: retry

Bobo1239 · 2018-10-06T18:07:03Z

Seems that your message didn't reach bors?
bors ping

bors · 2018-10-06T18:07:04Z

pong

jamesmunns · 2018-10-08T05:03:02Z

bors retry

bors · 2018-10-08T05:03:04Z

pong

jamesmunns · 2018-10-08T05:10:27Z

bors r+ p=10

206: Fix build issues r=jamesmunns a=malbarbo This fixes almost all current build issues. Only two issues are left: - thumb* tests, which requires using https://github.com/japaric/utest instead of https://github.com/japaric/cortest - netbsd build, which is failing with libc linking issues Co-authored-by: Marco A L Barbosa <[email protected]>

bors · 2018-10-08T06:14:57Z

Build succeeded

continuous-integration/travis-ci/push

malbarbo added 12 commits July 2, 2018 14:24

Update dependecies

6948871

Fix lint name error

b7d1223

Fix xargo build

eb1c79b

Update *-pc-windows-gnu docker image to 18.04

4dd9e6a

Fix compiler-builtins test

2da089f

Use https instead of ftp to download gcc dependecies

ea6b2b4

Disable run tests for thumb* targets

1a55ac8

Use http to download freebsd image

500bba6

Update netbsd patch urls

3b162e2

Enable testing CPP for targets that support it

c903903

Allows failures for x86_64-unknown-netbsd

c87cdc2

Disable CPP test for freebsd targets

cc0e75c

Dylan-DPC-zz previously approved these changes Sep 25, 2018

View reviewed changes

bgermann mentioned this pull request Sep 26, 2018

Replace gcc's download_prerequisites with Ubuntu packages #189

Closed

bors bot added a commit that referenced this pull request Sep 27, 2018

Try #206:

b233311

malbarbo added 2 commits September 28, 2018 07:34

Remove #![deny(warnings)] from xargo so env::home_dir() can be used

6959ee0

Disallows failures for x86_64-unknown-netbsd (the build issues was fi…

de27cd3

…xed upstream)

malbarbo dismissed Dylan-DPC-zz’s stale review via de27cd3 September 28, 2018 10:37

Dylan-DPC-zz mentioned this pull request Sep 29, 2018

remove export to make CI process less verbose #213

Closed

bgermann mentioned this pull request Oct 2, 2018

upgrade OpenSSL to 1.0.2p #180

Closed

Add workaround for travis error "Resource temporarily unavailable"

e22a562

malbarbo dismissed ryankurte’s stale review via e22a562 October 4, 2018 18:06

bgermann mentioned this pull request Oct 4, 2018

Update NetBSD patch locations #187

Closed

Dylan-DPC-zz approved these changes Oct 4, 2018

View reviewed changes

bors bot merged commit e22a562 into cross-rs:master Oct 8, 2018

malbarbo deleted the fixes branch October 16, 2018 13:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix build issues #206

Fix build issues #206

malbarbo commented Jul 2, 2018

malbarbo commented Jul 2, 2018

Bobo1239 commented Sep 19, 2018

bgermann commented Sep 20, 2018 •

edited

Loading

Bobo1239 commented Sep 23, 2018

bgermann commented Sep 24, 2018 •

edited

Loading

Bobo1239 commented Sep 25, 2018

bgermann commented Sep 27, 2018

Dylan-DPC-zz commented Sep 27, 2018

ryankurte commented Sep 27, 2018

Bobo1239 commented Sep 27, 2018 •

edited

Loading

ryankurte commented Sep 28, 2018

bors bot commented Sep 28, 2018

Dylan-DPC-zz commented Sep 29, 2018

bors bot commented Sep 29, 2018

Bobo1239 commented Sep 29, 2018

Dylan-DPC-zz commented Sep 29, 2018

malbarbo commented Oct 4, 2018

Dylan-DPC-zz commented Oct 4, 2018

ryankurte commented Oct 4, 2018

Bobo1239 commented Oct 4, 2018

Dylan-DPC-zz commented Oct 4, 2018

bors bot commented Oct 4, 2018

Bobo1239 commented Oct 5, 2018

Dylan-DPC-zz commented Oct 5, 2018

Dylan-DPC-zz commented Oct 5, 2018

Bobo1239 commented Oct 6, 2018

bors bot commented Oct 6, 2018

jamesmunns commented Oct 8, 2018

bors bot commented Oct 8, 2018

jamesmunns commented Oct 8, 2018

bors bot commented Oct 8, 2018

Fix build issues #206

Fix build issues #206

Conversation

malbarbo commented Jul 2, 2018

malbarbo commented Jul 2, 2018

Bobo1239 commented Sep 19, 2018

bgermann commented Sep 20, 2018 • edited Loading

Bobo1239 commented Sep 23, 2018

bgermann commented Sep 24, 2018 • edited Loading

Bobo1239 commented Sep 25, 2018

bgermann commented Sep 27, 2018

Dylan-DPC-zz commented Sep 27, 2018

ryankurte commented Sep 27, 2018

Bobo1239 commented Sep 27, 2018 • edited Loading

ryankurte commented Sep 28, 2018

bors bot commented Sep 28, 2018

try

Build failed

Dylan-DPC-zz commented Sep 29, 2018

bors bot commented Sep 29, 2018

Build failed

Bobo1239 commented Sep 29, 2018

Dylan-DPC-zz commented Sep 29, 2018

malbarbo commented Oct 4, 2018

Dylan-DPC-zz commented Oct 4, 2018

ryankurte commented Oct 4, 2018

Bobo1239 commented Oct 4, 2018

Dylan-DPC-zz commented Oct 4, 2018

bors bot commented Oct 4, 2018

Build failed

Bobo1239 commented Oct 5, 2018

Dylan-DPC-zz commented Oct 5, 2018

Dylan-DPC-zz commented Oct 5, 2018

Bobo1239 commented Oct 6, 2018

bors bot commented Oct 6, 2018

jamesmunns commented Oct 8, 2018

bors bot commented Oct 8, 2018

jamesmunns commented Oct 8, 2018

bors bot commented Oct 8, 2018

Build succeeded

bgermann commented Sep 20, 2018 •

edited

Loading

bgermann commented Sep 24, 2018 •

edited

Loading

Bobo1239 commented Sep 27, 2018 •

edited

Loading