Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add PKG_CONFIG_PATH for armhf image #1317

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

kingosticks
Copy link
Contributor

It doesn't hurt to have this also defined for arm-unknown-linux-gnueabihf despite apt package installation being disabled by default for this platform. Fixes #1316

It doesn't hurt to have this also defined for arm-unknown-linux-gnueabihf
despite apt package installation being disabled by default for this platform. Fixes cross-rs#1316
@kingosticks kingosticks requested a review from a team as a code owner August 23, 2023 10:49
@Emilgardis Emilgardis added the no-ci-targets PRs that do not affect any cross-compilation targets. label Aug 23, 2023
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Emilgardis
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 23, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit a599f20 into cross-rs:main Aug 23, 2023
22 checks passed
@kingosticks kingosticks deleted the set-pkgconfig-path-armhf branch August 23, 2023 13:11
@Emilgardis Emilgardis added this to the v0.3.0 milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-ci-targets PRs that do not affect any cross-compilation targets.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkgconfig search path not defined for arm-unknown-linux-gnueabihf
2 participants