You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently when we specify passthrough variables for cross, we cannot define the passthrough variable. docker run supports the --env VAR=VALUE syntax, so this should not require much work to support. In fact, removing the following lines and splitting on = to ensure that the key is not CROSS_RUNNER should fix this.
bail!("environment variable names must not contain the '=' character");
}
if var == "CROSS_RUNNER"{
bail!("CROSS_RUNNER environment variable name is reserved and cannot be pass through");
}
Describe why this would be a good inclusion for cross
Makes it a lot easier to use Cross.toml since you will not need wrapper scripts to define the environment variable value, or provide them every time on the command line.
The text was updated successfully, but these errors were encountered:
Delete unused toolchains to save ~600MB in our total image sizes. This is done by removing the toolchains for other targets in `/android-ndk/sysroot/usr/lib/`.
Closescross-rs#743.
750: Allow key-value pairs in config volumes. r=otavio a=Alexhuszagh
Allow volumes to use the `["VOL=/path/to/volume"]' syntax as well, so additional mount points can be defined by value in the `env.volumes` section of the config file. Allows the following syntax:
```toml
[build.env]
volumes = ["VOL=/path/to/mount/"]
```
Not implementing it with the `env.passthrough` was a complete oversight on my part, related to #743 and #748.
Co-authored-by: Alex Huszagh <[email protected]>
Checklist
Describe your request
Currently when we specify passthrough variables for cross, we cannot define the passthrough variable.
docker run
supports the--env VAR=VALUE
syntax, so this should not require much work to support. In fact, removing the following lines and splitting on=
to ensure that the key is notCROSS_RUNNER
should fix this.cross/src/docker.rs
Lines 118 to 124 in 1689de1
Describe why this would be a good inclusion for
cross
Makes it a lot easier to use
Cross.toml
since you will not need wrapper scripts to define the environment variable value, or provide them every time on the command line.The text was updated successfully, but these errors were encountered: