Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross.toml: runner setting is ignored #499

Closed
japaric opened this issue Dec 11, 2020 · 0 comments · Fixed by #500
Closed

Cross.toml: runner setting is ignored #499

japaric opened this issue Dec 11, 2020 · 0 comments · Fixed by #500
Labels
A-config Area: cross-toml config bug

Comments

@japaric
Copy link
Contributor

japaric commented Dec 11, 2020 

# Cross.toml
[target.aarch64-unknown-linux-gnu]
runner = ["qemu-system"]

The above setting is ignored by cross.

As you can see in https://github.com/rust-embedded/cross/blob/8df1f8cd2fe6d09cf312fd4c2cd498499ebc423d/src/docker.rs#L106 and https://github.com/rust-embedded/cross/blob/8df1f8cd2fe6d09cf312fd4c2cd498499ebc423d/src/docker.rs#L176

The CROSS_RUNNER variable is always set to "" in the docker container.

Apparently, the issue was (unintentionally) introduced in #344.
@japaric japaric added the bug label Dec 11, 2020
@japaric japaric mentioned this issue Dec 11, 2020
Merged
bors bot added a commit that referenced this issue Dec 12, 2020
@bors @japaric
Merge #497 #500
46d253d 
497: don't set RUSTFLAGS in aarch64-musl image r=reitermarkus a=japaric

instead use a linker wrapper to work around issue rust-lang/rust#46651
not setting RUSTFLAGS inside the container lets end users pass rustc flags via `.cargo/config`
this is an alternative to #464 that doesn't require bumping the MSRV of the `aarch64-unknown-linux-musl` target (that is the aarch64-musl image will continue to work with Rust 1.42 where bug rust-lang/rust#46651 is still presen )

500: use runner setting specified in Cross.toml r=reitermarkus a=japaric

fixes #499 

Co-authored-by: Jorge Aparicio <[email protected]>
bors bot added a commit that referenced this issue Dec 12, 2020
@bors @japaric
Merge #500
cc10f89 
500: use runner setting specified in Cross.toml r=reitermarkus a=japaric

fixes #499 

Co-authored-by: Jorge Aparicio <[email protected]>
bors bot added a commit that referenced this issue Dec 13, 2020
@bors @japaric
Merge #500
65f54c1 
500: use runner setting specified in Cross.toml r=reitermarkus a=japaric

fixes #499 

Co-authored-by: Jorge Aparicio <[email protected]>
@japaric japaric mentioned this issue Dec 14, 2020
Merged
@bors bors bot closed this as completed in 9bf60e7 Dec 14, 2020
@bors bors bot closed this as completed in #500 Dec 14, 2020
@Alexhuszagh Alexhuszagh added the A-config Area: cross-toml config label May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-config Area: cross-toml config bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use runner setting specified in Cross.toml cross-rs/cross
2 participants
@japaric @Alexhuszagh