-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conflict config with dependency #1619
Comments
The suggestion you saw about the warning is for making it into a hard error (I think?). The way to fix this is for getrandom to use workspace.metadata here: https://github.com/rust-random/getrandom/blob/7385d1348954b100044843bbd661faa0f19459f7/Cargo.toml#L94 This is unfortunate that it even happens, I think its our fault, were not handling the manifest correctly. Im not sure if this is fixed on newer cross, could you update cross and report back what you get?
|
hey thanks for looking into this. the suggestion in the warning actually bypass the check but raise build time error instead. and i tried installing the latest checkout
https://github.com/Watfaq/clash-rs/actions/runs/13030614288/job/36348854987?pr=686#step:5:87 would it make sense for me to send a PR to getrandom to change it to |
You could do that, its more correct. |
had a quick look here and the warning is originated from Lines 967 to 979 in 4090bec
however i don't have enough knowledge to understand what is the correct logic to make the build work. |
Edit: Actually, my issue might be unrelated? My issue looks like it might be due to optional workspace dependencies not being picked up in the right way. If I can reproduce, I'll file a new issue. |
Hey, we are running in the same error at youki - https://github.com/youki-dev/youki/actions/runs/13001125933/job/36259846628 After setting One potential reason we had this issue was that in our dep tree we had two versions of getrandom, 0.2.* and 0.3.0 . As this was dep of dep, we can't upgrade to latest, one dep still needs old version. As mentioned on this issue rust-random/getrandom#601 , it might be because cross might be running into issues when it finds two versions of same dep with their own cross config. However, we run the CI on x68_64/aarch64 and gun/musl combo on Linux. The getrandom specifies cross config only for netbsd https://github.com/rust-random/getrandom/blob/master/Cargo.toml#L94 . Is there anything I can help with to fix this issue? |
Checklist
Describe your issue
I have a Cross.toml for my workspace and today the build is giving error about conflict config from one of the dependencies
https://github.com/Watfaq/clash-rs/actions/runs/13025744515/job/36334424027?pr=686
i tried setting the env to disable the warning and the build actually fails so it looks like a real issue.
any idea how to fix the conflict?
What target(s) are you cross-compiling for?
x86_64-unknown-linux-gnu
Which operating system is the host (e.g computer cross is on) running?
What architecture is the host?
What container engine is cross using?
cross version
cross v0.2.5
Example
No response
Additional information / notes
No response
The text was updated successfully, but these errors were encountered: