Updated code for moveLeft function to address issue where code not executed #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 17, 2021 17:41
… that used the same name; changed the initialization method name so it no longer conflicted with the other library. updated the code for moveLeft - moved the code calling the beforeMoveLeft above the call to the main moveLeft callback. Removed the return before the call to self.callbacks.moveToLeft otherwise the rest of the code in the method is not executed.
…Left above the call to the main moveLeft callback. Removed the return before the call to self.callbacks.moveToLeft otherwise the rest of the code in the method is not executed.
|
Please run the gulp command as well so the minified version gets updated. |
|
Ran the gulp command and generated the minified version of the library. |
|
Is there anything else I need to do? |
|
@TheNephalim could you fix the conflicts please for the package-lock.json ? |
…- the variable isSafari was picking up a chrome browser as Safari if the intent is determine whether the browser is Chrome, there should be a separate variable like isChrome indicating the browser is a Chrome browser updated the fireSearch to always return true - considering getting rid of this method and the logic that uses it prefer to have it fire on any number of characters entered and not just two updated the code that searches the options to use native JavaScript - the logic in jQuery that searches for the options added an unacceptable level of overhead when the number of options went into the thousands; tested using a data set having close to 8000 options and the search function was very slow using native JavaScript instead of jQuery sped up the search funtion dramatically these updates are found in the methods filterItems and unfilterItems added a method searchItem that uses indexOf instead of RegExp because it is faster than RegExp added showItem and hideItem that duplicates the functionality of mHide and mShow using vanilla JavaScript instead of jQuery also added unfilterOptionGroup and filterOptionGroups that also use vanilla JavaScript instead of jQuery and a slightly different logic - i.e., the methods are self contained Updated the events function that handles the calls for filtering/unfiltering options to use the newly introduced methods
installed gulp-terser
updated code to use gulp-terser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated the code for moveLeft - moved the code calling the beforeMoveLeft above the call to the main moveLeft callback. Removed the return before the call to self.callbacks.moveToLeft otherwise the rest of the code in the method is not executed.