Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timezone to dateformatter #500

Merged
merged 8 commits into from
Mar 5, 2024
Merged

Add timezone to dateformatter #500

merged 8 commits into from
Mar 5, 2024

Conversation

mltbnz
Copy link
Member

@mltbnz mltbnz commented Mar 1, 2024

Context

It was assumed by the formatter that rides are only in german timezone which led to wrongly displayed starting times for other timezones.

Changes

  • set timeZone on Ride timeformatter

Testing

I set this argument for the TimeZone
Screenshot 2024-03-01 at 13 53 11
and used Lisbon coordinates lat: 38,7223 long: -9,1393

Data

[
  {
    "id": 19038,
    "title": "Massa Crítica Lisboa Março",
    "date_time": 1711731600, // 👈
    "location": "Pca Marques de de Pombal",
    "latitude": 38.725715191988,
    "longitude": -9.1504212236032,
    "enabled": true,
    "ride_type": "CRITICAL_MASS"
  }
]

👀

Screenshot 2024-03-01 at 13 47 20

@mltbnz mltbnz self-assigned this Mar 1, 2024
@mltbnz mltbnz requested a review from a team as a code owner March 1, 2024 12:56
@mltbnz mltbnz mentioned this pull request Mar 1, 2024
@mltbnz mltbnz force-pushed the add-timezone-to-timeformatter branch from 1dd0ea3 to f10e62f Compare March 1, 2024 13:49
@mltbnz mltbnz merged commit 3845d3c into main Mar 5, 2024
1 check passed
@mltbnz mltbnz deleted the add-timezone-to-timeformatter branch March 5, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant