Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies #198

Merged
merged 2 commits into from
Nov 25, 2019
Merged

Conversation

lennet
Copy link
Member

@lennet lennet commented Nov 22, 2019

I run the update_dependencies script + Bumped the min version of SDWebImage to 5.3

@lennet lennet requested a review from a team as a code owner November 22, 2019 21:53
Copy link
Member

@fbernutz fbernutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get this diff in Settings.bundle/com.mono0926.LicensePlist.latest_result.txt, when I run Xcode in your branch:

-LicensePlist Version: 2.7.1
\ No newline at end of file
+LicensePlist Version: 2.9.0
\ No newline at end of file

I think we should add these changes in this PR as well.

@lennet
Copy link
Member Author

lennet commented Nov 25, 2019

Good catch! Fixed that

Copy link
Member

@fbernutz fbernutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@fbernutz fbernutz merged commit fa15683 into criticalmaps:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants