Service registration with multiple checks #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrulatout
requested review from
dclaisse,
pierrecdn,
cpaillet,
mougams and
manu-ns
Without breaking compatibility, an optional extra_checks list of Checks allows us to register multiple checks during service registration. Note that this was still possible through check registration but requires multiple API calls.
mbrulatout
force-pushed
the
multi_checks
branch
from
4be216d to
664b497
Compare
dclaisse
approved these changes
Mar 15, 2024
mougams
reviewed
Mar 18, 2024
| @@ -836,6 +836,7 @@ def register( | |||
| http=None, | |||
| timeout=None, | |||
| enable_tag_override=False, | |||
| extra_checks=None, | |||
There was a problem hiding this comment.
Why not define an empty list instead of None?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without breaking compatibility, an optional extra_checks list of Checks allows us to register multiple checks during service registration.
Note that this was still possible through check registration but requires multiple API calls.
Also extended a test to register multiple checks and ensure both are passing