-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI fixes #543
Merged
Merged
CI fixes #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmigneault
added
the
feature/docker
Issue related to Docker application package execution.
label
Jul 6, 2023
github-actions
bot
added
ci/operations
Related to CI operations (actions, execution, install, builds, etc.)
ci/tests
Tests of the package and features
feature/cli
Issues or features related to CLI operations.
feature/CWL
Issue related to CWL support
feature/db
Related to database or datatype manipulation.
feature/oas
Issues related to OpenAPI specifications.
process/wps3
Issue related to WPS 3.x (REST-JSON) processes support
labels
Jul 7, 2023
…blem link anchors while validating pages themselves
fmigneault
force-pushed
the
fix-docker-worker
branch
from
July 7, 2023 15:37
a6befbe
to
f0d9aff
Compare
Codecov Report
@@ Coverage Diff @@
## master #543 +/- ##
==========================================
- Coverage 84.39% 84.38% -0.01%
==========================================
Files 79 79
Lines 17596 17601 +5
Branches 2670 2670
==========================================
+ Hits 14850 14853 +3
- Misses 2017 2019 +2
Partials 729 729
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci/doc
Issue related to documentation of the package
ci/operations
Related to CI operations (actions, execution, install, builds, etc.)
ci/tests
Tests of the package and features
feature/cli
Issues or features related to CLI operations.
feature/CWL
Issue related to CWL support
feature/db
Related to database or datatype manipulation.
feature/docker
Issue related to Docker application package execution.
feature/oas
Issues related to OpenAPI specifications.
process/wps3
Issue related to WPS 3.x (REST-JSON) processes support
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker build issue identified in https://github.com/crim-ca/weaver/actions/runs/5476798191/jobs/9974868828?pr=542
Fixes
Since the CI fails with either combination of those fixes individually (docker build fail or lint checks fail), combine them all in one.
weaver-worker
image due to unresolveddocker-ce-cli
package.Installation is updated according to the reference documentation (https://docs.docker.com/engine/install/debian/).
bytes
instead ofstr
) for some handlers inopen_module_resource_file
.jsonschema.validators.RefResolver
reference injsonschema>=4.18.0
caused by refactor(see https://github.com/python-jsonschema/jsonschema/blob/main/CHANGELOG.rst#v4180
and Replace
$ref
&$dynamicRef
support /RefResolver
with the new referencing library python-jsonschema/jsonschema#1049).