Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ingress prefix #82

Merged
merged 2 commits into from
Jan 11, 2023
Merged

Conversation

bdalpe
Copy link
Contributor

@bdalpe bdalpe commented Oct 3, 2022

AWS does not support wildcards in the path

AWS does not support wildcards in the path
@bieron
Copy link
Collaborator

bieron commented Oct 4, 2022

@bdalpe are you sure this is true? https://www.stacksimplify.com/aws-eks/aws-alb-ingress/kubernetes-aws-alb-ingress-context-path-based-routing/#step-04-create-alb-ingress-context-path-based-routing-kubernetes-manifest has an example with wildcards, even one that's exactly /*

spec:
  rules:
    - http:
        paths:
          - path: /app1/*
            backend:
              serviceName: app1-nginx-nodeport-service
              servicePort: 80                        
          - path: /app2/*
            backend:
              serviceName: app2-nginx-nodeport-service
              servicePort: 80            
          - path: /*

@bdalpe
Copy link
Contributor Author

bdalpe commented Oct 4, 2022

Just tested on AWS with the EKS ALB Controller and received an error:

Failed build model due to ingress: default/cribl-ldr-leader: prefix path shouldn't contain wildcards: /*

The official documentation does not show this: https://kubernetes.io/docs/concepts/services-networking/ingress/#examples

@bdalpe
Copy link
Contributor Author

bdalpe commented Oct 4, 2022

@bieron maybe we should make this a variable instead of hard-coding the value?

@bdalpe bdalpe marked this pull request as draft October 6, 2022 17:41
@bdalpe bdalpe marked this pull request as ready for review January 11, 2023 13:55
@bdalpe bdalpe self-assigned this Jan 11, 2023
@bdalpe bdalpe added the enhancement New feature or request label Jan 11, 2023
@bdalpe bdalpe merged commit cd2bfca into criblio:master Jan 11, 2023
@bdalpe bdalpe deleted the fix-leader-ingress-prefix branch January 11, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants