Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump GitHub Actions dependencies & fix typos #206

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Bump GitHub Actions dependencies & fix typos #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13b2ce6
Update dependencies in GitHub PR workflow
michalbiesek Aug 13, 2024
c5b3892
Fix typo(s)
michalbiesek Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,28 +7,26 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout repo
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install Helm
uses: azure/setup-helm@v3
with:
version: 3.12.3
uses: azure/[email protected]

- name: Install unittest plugin
run: helm plugin install https://github.com/helm-unittest/helm-unittest --version 0.3.5
run: helm plugin install https://github.com/helm-unittest/helm-unittest --version 0.5.2

- name: helm lint
run: helm lint helm-chart-sources/*

- name: helm unittest
run: helm unittest helm-chart-sources/*

- uses: actions/setup-go@v4
- uses: actions/setup-go@v5
with:
go-version: '>=1.19.0'

- name: Install kubeconform
run: go install github.com/yannh/kubeconform/cmd/[email protected].3
run: go install github.com/yannh/kubeconform/cmd/[email protected].7

- name: kubeconform
run: ./scripts/kubeconform.sh
4 changes: 2 additions & 2 deletions common_docs/EXTRA_EXAMPLES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,12 +124,12 @@ If you specify a `extraVolumeMounts.claimTemplate` attribute (and you have speci
<dt>readOnly</dt>
<dd>Whether to mount the volume read-only or read/write – default is read/write. </dd>
<dt>claimTemplate</dt>
<dd>If this is set, it decribes the PVC that will be created for each pod. <em>Statefulset deployment only.</em></dd>
<dd>If this is set, it describes the PVC that will be created for each pod. <em>Statefulset deployment only.</em></dd>
</dl>

### Example
This example mounts two extra directories:
* An `emptyDir`, mounted on /var/lib/testin
* An `emptyDir`, mounted on /var/lib/testing
* An existing PVC, called `test-volume`, mounted on `/var/tmp/test-volume`

```
Expand Down
2 changes: 1 addition & 1 deletion helm-chart-sources/logstream-leader/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ persistence:
# -- Disable this to use an emptyDir for CRIBL_VOLUME_DIR config storage
enabled: true
# -- Unset claimName to use the Helm Release name as the PVC name
# This is set for backwards compatability purposes
# This is set for backwards compatibility purposes
claimName: leader-config-claim
# -- Set storageClassName to use a class other than the default
# Will prioritize this value above the value defined in config.scName
Expand Down
Loading