-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to disable the use of inotify #92
Conversation
Add a new InitCNINoInotify function to allow the use of OCICNI without the use of inotify. For some workloads it is not required to watch the cni config directory. With podman v3.2 we started using OCICNI for rootless users as well. However the use of inotify is restricted by sysctl values (fs.inotify.max_user_instances and fs.inotify.max_user_watches). By default only 128 processes can use inotify. Since this limit is easy to reach and inotify is not required for our use case it would be great to have this option to disable it. see containers/podman#10686 Signed-off-by: Paul Holzinger <[email protected]>
Pull Request Test Coverage Report for Build 943565137
💛 - Coveralls |
/approve LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, Luap99, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@saschagrunert @haircommander Would it be possible that someone creates a branch without commit f9d4247 and 8480c61? I want to vendor this into podman to fix a critical bug but this would require a bump to CNI v1.0.0-rc1. This is not possible because breaking changes in CNI, podman and another library still depend on v0.8.1. |
We do not have a mechanism in place for something like this, yet. I'm not opposed in creating a new branch, WDYT @haircommander ? |
/lgtm |
Add a new InitCNINoInotify function to allow the use of OCICNI without
the use of inotify.
For some workloads it is not required to watch the cni config directory.
With podman v3.2 we started using OCICNI for rootless users as well.
However the use of inotify is restricted by sysctl values
(fs.inotify.max_user_instances and fs.inotify.max_user_watches).
By default only 128 processes can use inotify.
Since this limit is easy to reach and inotify is not required for our
use case it would be great to have this option to disable it.
see containers/podman#10686