Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freshen OWNERS with crio folks #89

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

baude
Copy link
Contributor

@baude baude commented Apr 21, 2021

This is to request that Sascha and Peter both be added as approvers and
assignees for ocicni. They both hold key roles on the crio team and can
assist in the maintainence of this package.

Signed-off-by: Brent Baude [email protected]

This is to request that Sascha and Peter both be added as approvers and
assignees for ocicni.  They both hold key roles on the crio team and can
assist in the maintainence of this package.

Signed-off-by: Brent Baude <[email protected]>
@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 21, 2021
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 771062850

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.694%

Totals Coverage Status
Change from base Build 726969682: 0.0%
Covered Lines: 473
Relevant Lines: 720

💛 - Coveralls

@saschagrunert saschagrunert added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 21, 2021
@baude
Copy link
Contributor Author

baude commented Apr 21, 2021

/release-note-none

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, mrunalp, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2021
@mrunalp
Copy link
Member

mrunalp commented Apr 21, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2021
@openshift-merge-robot openshift-merge-robot merged commit 10dec7e into cri-o:master Apr 21, 2021
@haircommander
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants