Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocicni: add new functions that take a Context #72

Merged
merged 1 commit into from
Apr 22, 2020
Merged

ocicni: add new functions that take a Context #72

merged 1 commit into from
Apr 22, 2020

Conversation

dcbw
Copy link
Collaborator

@dcbw dcbw commented Apr 22, 2020

@openshift-ci-robot openshift-ci-robot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Apr 22, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2020
mccv1r0
mccv1r0 reviewed Apr 22, 2020
View reviewed changes
Copy link
Contributor

@mccv1r0 mccv1r0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@mrunalp
Copy link
Member

mrunalp commented Apr 22, 2020

/lgtm

@mrunalp mrunalp added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2020
@mrunalp mrunalp merged commit 513ef78 into cri-o:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mccv1r0 mccv1r0 mccv1r0 left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp

@rajatchopra rajatchopra Awaiting requested review from rajatchopra

Assignees

@mrunalp mrunalp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dcbw @openshift-ci-robot @mrunalp @mccv1r0