Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply golangci-lint config and fixes #190

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Apply golangci-lint config and fixes #190

merged 1 commit into from
Mar 14, 2024

Conversation

saschagrunert
Copy link
Member 

None

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 13, 2024
@openshift-ci openshift-ci bot requested review from mrunalp and sameo March 13, 2024 08:20
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2024
@saschagrunert saschagrunert force-pushed the lint branch 6 times, most recently from 9c97def to 7ed6306 Compare March 13, 2024 08:30
@saschagrunert
Copy link
Member Author

@cri-o/cri-o-maintainers PTAL

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8261690145

Details

  • 41 of 61 (67.21%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-6.1%) to 59.9%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tools/ocicnitool/ocicnitool.go 0 3 0.0%
pkg/ocicni/ocicni.go 41 47 87.23%
pkg/ocicni/util_linux.go 0 11 0.0%
Totals Coverage Status
Change from base Build 8260901268: -6.1%
Covered Lines: 481
Relevant Lines: 803
💛 - Coveralls

@kwilczynski
Copy link
Member

/apply
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2024
@kwilczynski
Copy link
Member

@saschagrunert, thank you!

This project needs some more love and care! 🎉

@openshift-merge-bot openshift-merge-bot bot merged commit 79359c6 into cri-o:master Mar 14, 2024
5 checks passed
@saschagrunert saschagrunert deleted the lint branch March 14, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp

@sameo sameo Awaiting requested review from sameo

Assignees

@kwilczynski kwilczynski

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saschagrunert @coveralls @kwilczynski