Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply small cleanups and error check paths #187

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Apply small cleanups and error check paths #187

merged 1 commit into from
Mar 13, 2024

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Mar 12, 2024 •
edited
Loading

@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 12, 2024
@openshift-ci openshift-ci bot requested review from mrunalp and rajatchopra March 12, 2024 10:36
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2024
@coveralls
Copy link

coveralls commented Mar 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8248208003

Details

  • 6 of 18 (33.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 66.017%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/ocicni/ocicni.go 6 18 33.33%
Totals Coverage Status
Change from base Build 8152763335: -0.2%
Covered Lines: 474
Relevant Lines: 718
💛 - Coveralls

@kwilczynski
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d17a01b into cri-o:master Mar 13, 2024
4 checks passed
@saschagrunert saschagrunert deleted the cleanups branch March 13, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwilczynski kwilczynski kwilczynski left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp

@rajatchopra rajatchopra Awaiting requested review from rajatchopra

Assignees

@kwilczynski kwilczynski

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saschagrunert @coveralls @kwilczynski