ci: remove Travis CI and fix some issues with Github Actions

Let's join the 21st century.

Signed-off-by: Dan Williams <[email protected]>

.github/workflows/test.yaml

@@ -24,7 +24,6 @@ jobs:
           for arch in ${LINUX_ARCHES}; do
             echo "Building for arch $arch"
             GOARCH=$arch make
-            rm bin/*
           done
 
   test-linux:
@@ -41,13 +40,11 @@ jobs:
         env:
           GO111MODULE: off
         run: |
-          go get golang.org/x/tools/cmd/cover
           go get github.com/modocache/gover
           go get github.com/mattn/goveralls
-          go get -t ./...
 
       - name: test
-        run: PATH=$PATH:$(go env GOPATH)/bin COVERALLS=1 ./test_linux.sh
+        run: PATH=$PATH:$(go env GOPATH)/bin COVERALLS=1 make check
 
       - name: Send coverage to coveralls
         env:

.gitignore

@@ -2,3 +2,4 @@
 *.o
 *.orig
 ocicnitool
+*.coverprofile

hack/test-go.sh

@@ -16,8 +16,6 @@ if [ ! -z "${COVERALLS:-""}" ]; then
         testrun "-covermode set -coverprofile ${i}.coverprofile ${t}"
         i=$((i+1))
     done
-    gover
-    goveralls -service=travis-ci -coverprofile=gover.coverprofile
 else
     echo "without coverage profile generation..."
     testrun "./..."

pkg/ocicni/ocicni.go

@@ -810,7 +810,7 @@ func buildCNIRuntimeConf(podNetwork *PodNetwork, ifName string, runtimeConfig Ru
 	}
 
 	// Propagate existing CNI_ARGS to non-k8s consumers
-	for _, kvpairs := range strings.Split(os.Getenv("CNI_ARGS"), ";"){
+	for _, kvpairs := range strings.Split(os.Getenv("CNI_ARGS"), ";") {
 		if keyval := strings.SplitN(kvpairs, "=", 2); len(keyval) == 2 {
 			rt.Args = append(rt.Args, [2]string{keyval[0], keyval[1]})
 		}