Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.17] bump c/image to 5.2.1 #3239

Merged

Conversation

haircommander
Copy link
Member

should fix #3233
Signed-off-by: Peter Hunt [email protected]

Signed-off-by: Peter Hunt <[email protected]>
@openshift-ci-robot openshift-ci-robot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Feb 10, 2020
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 10, 2020
@codecov
Copy link

codecov bot commented Feb 10, 2020

Codecov Report

Merging #3239 into release-1.17 will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           release-1.17    #3239   +/-   ##
=============================================
  Coverage         44.77%   44.77%           
=============================================
  Files                91       91           
  Lines              7585     7585           
=============================================
  Hits               3396     3396           
  Misses             3890     3890           
  Partials            299      299

@rhatdan
Copy link
Contributor

rhatdan commented Feb 10, 2020

/retest

@vrothberg
Copy link
Member

I guess we need to cherry-pick commit 1d7d7a0 to make it pass.

label.Relabel() can now return errors wrapped in context information, so
unwrap them before comparing them to ENOTSUP.

Signed-off-by: Nalin Dahyabhai <[email protected]>
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2020
@mrunalp
Copy link
Member

mrunalp commented Feb 10, 2020

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants