User system refacto #422
Open
User system refacto #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mRoca
force-pushed
the
user-system-refacto
branch
4 times, most recently
from
7eb7206
to
9023323
Compare
|
@vincentchalamon je viens de terminer la partie des templates / email & tests, j'ai l'impression que tout devrait être bon, t'as fait un super taf ! T'aurais le temps de te replonger dedans histoire de voir si j'ai pas oublié un truc ? |
This was
linked to
issues
Nov 8, 2020
|
@mRoca Ça me semble bien pour cette PR, sauf la CI qui gueule (les tests à corriger je pense). Il faudrait également mettre à jour le fichier .github/workflows/ci.yml pour corriger une dépréciation (qui est en fait une faille de sécurité). |
|
J'ai vu pour les tests: c'est à cause de mes dernières modifs pour les emails. Je fix tout ça ce soir |
mRoca
force-pushed
the
user-system-refacto
branch
4 times, most recently
from
781791d
to
c96c81f
Compare
|
@vincentchalamon t'en penses quoi ? |
vincentchalamon
suggested changes
Nov 13, 2020
mRoca
force-pushed
the
user-system-refacto
branch
from
c96c81f
to
e5acd49
Compare
vincentchalamon
approved these changes
Nov 13, 2020
* Prepare Behat scenarios for User system refacto (#339) * Refacto User login * Add reset password * Add Organization promote/revoke User * Add ROLE_SUPER_ADMIN * Add User impersonification for super-admin only * Remove useless ROLE_VOLUNTEER * wip * Fix PHP-CS Co-authored-by: Michel Roca <[email protected]>
mRoca
force-pushed
the
user-system-refacto
branch
from
e5acd49
to
f90c90d
Compare
mRoca
force-pushed
the
user-system-refacto
branch
from
f90c90d
to
b241870
Compare
|
TODO before merging:
|
mRoca
force-pushed
the
user-system-refacto
branch
3 times, most recently
from
943bf93
to
4ace493
Compare
mRoca
force-pushed
the
user-system-refacto
branch
from
4ace493
to
dc84ca4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.