Add support for hardware security module (HSM) signing. #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
LGTM. Note to self: fix linter then merge. :) |
|
Hi @crewjam! Is there anything I can do to assist with this? Let me know! Note: Just rebased on top of current main. |
added 2 commits
April 11, 2023 15:37
goxmldsig was recently updated to support HSMs. This is done by supporting signing using the `crypto.Signer` directly, which is how HSMs are able to sign things in golang. This commit adds a new field `Signer` to the `IdentityProvider` which takes precedence over the `Key` field when creating the `SigningContext`. The `Key` field has been left in place to maintain backwards compatibility. Tests have been updated to verify that this functions, and the `samlidp` example identity provider has been updated such that it now supports a `Signer` option. Additionally, `NewIdentifyProviderTest` has been corrected to `NewIdentityProviderTest`.
|
@crewjam Hey, sorry to bother. Any way this could get merged soon? Thank you! |
mdwn
pushed a commit
to gravitational/teleport
that referenced
this pull request
Apr 20, 2023
Update the crewjam/saml dependency to pull in HSM support from crewjam/saml#503.
github-merge-queue bot
pushed a commit
to gravitational/teleport
that referenced
this pull request
Apr 20, 2023
Update the crewjam/saml dependency to pull in HSM support from crewjam/saml#503.
github-actions bot
pushed a commit
to gravitational/teleport
that referenced
this pull request
Apr 20, 2023
Update the crewjam/saml dependency to pull in HSM support from crewjam/saml#503.
mdwn
pushed a commit
to gravitational/teleport
that referenced
this pull request
Apr 20, 2023
Update the crewjam/saml dependency to pull in HSM support from crewjam/saml#503.
github-merge-queue bot
pushed a commit
to gravitational/teleport
that referenced
this pull request
Apr 20, 2023
Update the crewjam/saml dependency to pull in HSM support from crewjam/saml#503.
github-merge-queue bot
pushed a commit
to gravitational/teleport
that referenced
this pull request
Apr 20, 2023
* Update crewjam/saml dependency. Update the crewjam/saml dependency to pull in HSM support from crewjam/saml#503. * Fix /x/time location in go.mod
mgyongyosi
pushed a commit
to grafana/saml
that referenced
this pull request
Oct 25, 2023
(cherry picked from commit 34930b2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goxmldsig was recently updated to support HSMs. This is done by supporting signing using the
crypto.Signerdirectly, which is how HSMs are able to sign things in golang.This commit adds a new field
Signerto theIdentityProviderwhich takes precedence over theKeyfield when creating theSigningContext. TheKeyfield has been left in place to maintain backwards compatibility.Tests have been updated to verify that this functions, and the
samlidpexample identity provider has been updated such that it now supports aSigneroption. Additionally,NewIdentifyProviderTesthas been corrected toNewIdentityProviderTest.