Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: modify mm order #144

Merged
merged 8 commits into from
Feb 13, 2023
Merged

refactor!: modify mm order #144

merged 8 commits into from
Feb 13, 2023

Conversation

kingcre
Copy link
Contributor

@kingcre kingcre commented Feb 9, 2023

Description

Previously, market makers could only place orders based on the chain's pre-defined logic(~10 orders on even ticks).
To give market makers full control over their orders, make MsgMMOrder almost same as MsgLimitOrder.
The only difference between two msgs is that a market maker can place only 15(this parameter, MaxNumMMOrdersPerPair can be changed) orders through MsgMMOrder per each pair.

Tasks

  • Modify MsgMMOrder's behavior
  • Refactor order-related keeper methods
  • Write upgrade handler

References


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@kingcre kingcre self-assigned this Feb 9, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 9, 2023
@kingcre kingcre marked this pull request as ready for review February 10, 2023 13:26
x/liquidity/legacy/v4/store.go Outdated Show resolved Hide resolved
app/upgrades/mainnet/v5/upgrade.go Outdated Show resolved Hide resolved
@kingcre kingcre requested a review from crypin February 13, 2023 03:39
@kingcre kingcre merged commit fd1ccc2 into main Feb 13, 2023
@kingcre kingcre deleted the mm-order branch August 1, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation x/liquidity
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants