Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bugs fixes #606

Merged
merged 9 commits into from
Mar 27, 2024
Merged

fix: bugs fixes #606

merged 9 commits into from
Mar 27, 2024

Conversation

bhavanakarwade
Copy link
Contributor

@bhavanakarwade bhavanakarwade commented Mar 20, 2024 •
edited
Loading

What ?

  • Worked on below issues:
  1. https://github.com/credebl/automation-test-suite/issues/258
  2. https://github.com/credebl/automation-test-suite/issues/374
  3. https://github.com/credebl/automation-test-suite/issues/375
  4. https://github.com/credebl/automation-test-suite/issues/376
  5. https://github.com/credebl/automation-test-suite/issues/288

Why?

  • To enhance the reliability and efficiency of the test suite, ensuring it accurately reflects the behavior of the ecosystem dashboard and associated APIs.

How?

  • Debugging and fixing the code related to the search functionality on the ecosystem dashboard.
  • Modifying the API request body to remove the unnecessary orgId requirement.
  • Adjusting the API response handling to include the missing data.
  • Adding the required 'credentialExchangeId' field to the API response.
  • Updating the message displayed to ensure its accuracy when retrieving issued credentials for a specific organization.

@bhavanakarwade bhavanakarwade self-assigned this Mar 20, 2024
nishad-ayanworks
nishad-ayanworks approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@nishad-ayanworks nishad-ayanworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

KulkarniShashank
KulkarniShashank approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@KulkarniShashank KulkarniShashank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

tipusinghaw
tipusinghaw approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@tipusinghaw tipusinghaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bhavanakarwade bhavanakarwade merged commit c9132be into develop Mar 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tipusinghaw tipusinghaw tipusinghaw approved these changes

@nishad-ayanworks nishad-ayanworks nishad-ayanworks approved these changes

@KulkarniShashank KulkarniShashank KulkarniShashank approved these changes

Assignees

@bhavanakarwade bhavanakarwade

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bhavanakarwade @KulkarniShashank @nishad-ayanworks @tipusinghaw