Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Decline endorsement request by lead #145

Merged
merged 6 commits into from
Oct 12, 2023

Conversation

pallavighule
Copy link
Contributor

What

  • Developed Decline endorsement request by lead feature

Why

  • Lead can decline the endorsement transaction request if status of endorsement transaction is requested.

@pallavighule pallavighule added the enhancement New feature or request label Oct 11, 2023
@pallavighule pallavighule self-assigned this Oct 11, 2023
Signed-off-by: pallavicoder <[email protected]>
summary: 'Decline Endorsement Request By Lead',
description: 'Decline Endorsement Request By Lead'
})
// @UseGuards(AuthGuard('jwt'), EcosystemRolesGuard, OrgRolesGuard)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the commented code and apply role guards properly

Copy link
Contributor

@nishad-ayanworks nishad-ayanworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the comments on PR.

Signed-off-by: pallavicoder <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@nishad-ayanworks nishad-ayanworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@nishad-ayanworks nishad-ayanworks merged commit c760cd0 into develop Oct 12, 2023
3 checks passed
@nishad-ayanworks nishad-ayanworks deleted the RejectEndorsementRequestByLead branch December 6, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants