Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What are the props on NavbarBrand doing? #5

Closed
tylim88 opened this issue May 13, 2019 · 3 comments · Fixed by #16
Closed

What are the props on NavbarBrand doing? #5

tylim88 opened this issue May 13, 2019 · 3 comments · Fixed by #16
Labels
enhancement New feature or request question Further information is requested typo

Comments

@tylim88
Copy link

tylim88 commented May 13, 2019

!!! IF YOU DO NOT USE THIS ISSUES TEAMPLATE, YOUR ISSUE IS LIABLE TO BEING IGNORED BY US

Prerequisites

Please answer the following questions for yourself before submitting an issue.

  • [x ] I am running the latest version
  • [x ] I checked the documentation and found no answer
  • [x ] I checked to make sure that this issue has not already been filed
  • [x ] I'm reporting the issue to the correct repository (for multi-repository projects)

Expected Behavior

expecting complete documentation of component properties example:NavBarBrand

Current Behavior

no complete documentation, not even in reactstrap official documentation
https://reactstrap.github.io/components/navbar/#app

Failure Information (for bugs)

Please help provide information about the failure if this is a bug. If it is not a bug, please remove the rest of this template.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. step 1
  2. step 2
  3. you get it...

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

  • Device:
  • Operating System:
  • Browser and Version:

Failure Logs

Please include any relevant log snippets or files here.

@tylim88
Copy link
Author

tylim88 commented May 13, 2019

need doc

@einazare
Copy link
Contributor

Hello there, @tylim88 ,

Thank you for your interest in working with our products.
Actually, we've done exactly what the NavbarBrand props tell us:
Screen Shot 2019-05-13 at 6 05 55 PM
As you can see in the above image, on the official Reactstrap docs, it states that you can use the tag property to change the default div rendering tag of this component to something else.
We've decided to render the NavbarBrand as a Link from react-router-dom. When you do so, when you change the rendering tag of a component from Reactstrap, you need to add on that component, all the props that comes with the changed rendering tag, in this sample code, it is the to prop. Each Link from react-router-dom has to have set a to prop. You can read more about how to work with routing in react here: https://github.com/ReactTraining/react-router
The other tags, data-placement, rel and title are left there by mistake. Anyhow, all of the Reactstrap components let you add all the normal props from the html tags.

I'll add a typo label to this issue, and I'll delete those in our next update.

Hope this information helps you.

All the best,
Manu
ReactJS Developer at Creative-Tim.com (http://creative-tim.com/)

Trying to help the open source community:

If you've liked what you saw, help me with a comment, like, share or subscribe.

@einazare einazare added enhancement New feature or request question Further information is requested typo labels May 13, 2019
@einazare einazare changed the title Documentation? What are the props on NavbarBrand doing? May 13, 2019
@tylim88
Copy link
Author

tylim88 commented May 13, 2019

Thank you @einazare

Your answer is very helpful

@tylim88 tylim88 closed this as completed May 13, 2019
@einazare einazare reopened this May 13, 2019
einazare added a commit that referenced this issue Mar 13, 2020
einazare added a commit that referenced this issue Mar 13, 2020
einazare added a commit that referenced this issue Mar 13, 2020
Closes #8
Closes #7
Closes #5
Closes #4
Closes #2
Closes #1
This was referenced Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested typo
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants