Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite tests for license code generation #195

Merged
merged 9 commits into from
Oct 29, 2020

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Oct 21, 2020

Fixes

Related to #125 and #117

Description

This PR reworks the tests for license code generation to test the correctness of the generated license code. Instead of hardcoding all the values, we test returned values for correctness.
In addition, previously, generated rich text code was not tested in unit tests because the functional i18n component was not mounted in tests, only showing an i18n stub.

Several items were also fixed:

  • When a user inputs the profile URL, but not the name, an unnecessary empty element was inserted into the Rich Text license code.
  • CC0 slug for icons is generated correctly
  • 'http' is added to the generated code, making it absolute, instead of relative. Previously, the relative URL resulted in links starting with the chooser's URL (or localhost).
  • Store is now initialized separately, making it easier to set up for testing.

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner October 21, 2020 20:23
@obulat obulat requested review from akmadian and removed request for a team October 21, 2020 20:23
# Conflicts:
#	src/utils/license-utilities.js
#	tests/unit/specs/components/LicenseCode.spec.js
#	tests/unit/specs/utils/license-uilities.test.js
@obulat obulat changed the title Rework tests for license code generation and fix some code bugs Rewrite tests for license code generation Oct 29, 2020
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really, really wonderful work! I love the jsdoc usage in projects—I'm going to make it a part of our JS code standards when I get those published.

@obulat obulat merged commit d61ff90 into creativecommons:master Oct 29, 2020
@obulat obulat deleted the url-generation branch October 29, 2020 21:22
@obulat obulat mentioned this pull request Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants