Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of non-canonical license URIs #286

Closed
fkohrt opened this issue Jan 8, 2021 · 3 comments
Closed

Use of non-canonical license URIs #286

fkohrt opened this issue Jan 8, 2021 · 3 comments
Assignees
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work

Comments

@fkohrt
Copy link
Contributor

fkohrt commented Jan 8, 2021

Description

The canonical URIs of the CC licenses all start with http://, as can be verified by the RDF source of truth. The scheme is part of the URI, so there's a semantic difference between http://creativecommons.org/licenses/by/4.0/ and https://creativecommons.org/licenses/by/4.0/.

Browsers tend to prefer the HTTPS version of a site anyways (Firefox: HTTPS-Only Mode, Chromium: upgraded HTTPS navigations), so this is increasingly unlikely to be a security/privacy issue.

Reproduction

See e.g. here, where additionally chooserRef is appended:

const chooserRef = '?ref=chooser-v1'
/**
* Returns url to license from short license name with version number (eg. 'CC BY 4.0')
* @param {LicenseAttributes} attr license attributes object
* @param {'web'|'print'} mode? (?ref=chooser-v1, target and rel are added to the end of the link if mode is web)
* @returns {string} url of the license information page
*/
function licenseURL(attr, mode = 'web') {
if (attr.BY === undefined) throw new Error('Cannot return URL when BY attribute is undefined')
const linkRef = mode === 'web' ? chooserRef : ''
if (attr.BY === false) {
return `https://creativecommons.org/publicdomain/zero/1.0${linkRef}`
}
let short = attrToShort(attr).toLowerCase().slice(3)
short = short.slice(0, short.length - 4)
return `https://creativecommons.org/licenses/${short}/4.0${linkRef}`
}

Or here, where also a trailing slash is missing:

URL: 'https://creativecommons.org/licenses/by/4.0',

Other instances are tests/unit/specs/components/LicenseHTML.spec.js and tests/e2e/specs/LicenseDetailsCard.js.

Expectation

Use the license URIs from the RDF datastore at cc.licenserdf.

Additional context

There are two ongoing discussions about making canonical URIs more prominent at other places:

@fkohrt fkohrt added 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents labels Jan 8, 2021
@obulat
Copy link
Contributor

obulat commented Jan 8, 2021

Thank you for bringing this issue up, @fkohrt ! I will respond as soon as we have discussed this issue with the other members of the team.

@TimidRobot TimidRobot self-assigned this Jan 12, 2021
@TimidRobot TimidRobot removed their assignment May 12, 2021
Abhishek140501 added a commit to Abhishek140501/chooser that referenced this issue Jul 3, 2023
@fkohrt
Copy link
Contributor Author

fkohrt commented Sep 13, 2023

I believe this can be closed due to cc-archive/cc.licenserdf#7 (comment):

Add owl:sameAs element with HTTPS URL

@TimidRobot TimidRobot self-assigned this Apr 8, 2024
@TimidRobot TimidRobot added 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work and removed 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Apr 8, 2024
@TimidRobot TimidRobot removed their assignment Apr 8, 2024
@TimidRobot
Copy link
Member

This was resolved by the production release of the new CC Legal Tools (creativecommons/cc-legal-tools-app & creativecommons/cc-legal-tools-data), that include owl:sameAs, on 2023-09-27.

@TimidRobot TimidRobot self-assigned this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work
Projects
None yet
Development

No branches or pull requests

3 participants