Skip to content

Commit

Permalink
Notify about intentionally using blocking io on Darwin
Browse files Browse the repository at this point in the history
  • Loading branch information
sio committed Apr 28, 2023
1 parent 75e52f1 commit 3abf458
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions io_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,13 @@ func TestReadClose(t *testing.T) {

// Open pty and setup watchdogs for graceful and not so graceful failure modes
func prepare(t *testing.T) (ptmx *os.File, done func()) {
if runtime.GOOS == "darwin" {
t.Log("creack/pty uses blocking i/o on darwin intentionally:")
t.Log("> https://github.com/creack/pty/issues/52")
t.Log("> https://github.com/creack/pty/pull/53")
t.Log("> https://github.com/golang/go/issues/22099")
t.SkipNow()
}

// Due to data race potential in (*os.File).Fd()
// we should never run these two tests in parallel
Expand Down

0 comments on commit 3abf458

Please sign in to comment.