Add usb-mass-storage and deviceId support #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In macOS 13, there are now 2 different storage devices, VirtioBlk and USBMassStorage. This commit introduces a base StorageConfig to allow code sharing between the 2 implementations.
The AddToVirtualMachineConfig() API is starting to show its limitations as we now want to add multiple storage devices to the VM. AddToVirtualMachineConfig() creates a single vz.StorageDeviceConfiguration object, and then passes a 1-element array to vz.SetStorageDevicesVirtualMachineConfiguration() This commit introduces toVz() methods which should help to address this limitation. They make it possible to first create all the vz.StorageDeviceConfiguration objects from different config.VirtioDevice objects, and then pass these all at once to to vz.SetStorageDevicesVirtualMachineConfiguration()
I'll need it to be able to first generate a list of vz.StorageDeviceConfiguration, and then add these to vz.VirtualMachineConfiguration. This will allow to have multiple storage devices added to a VM.
This makes use of the toVz() API and of the VMConfig API added in the previous commits in order to first generate a []vz.StorageDeviceConfiguration before calling vz.SetStorageDevicesVirtualMachineConfiguration() with this array.
This tests conversion of virtio devices to command line and then parsing again the generated command line.
anjannath
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the existing code to allow multiple storage devices to be add to the VM.
Then this adds support for USB mass storage devices (to be used for example with ISO files), and for
deviceIdwhich is useful to tag the disk images to easily identify them in the VM.