cloudinit: leverage virtio-blk to push cloud-init configuration #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
lstocchi
force-pushed
the
i123
branch
2 times, most recently
from
e96048c
to
c27487c
Compare
lstocchi
force-pushed
the
i123
branch
2 times, most recently
from
92b9ec6
to
f59937d
Compare
lstocchi
changed the title
cfergeau
changed the title
lstocchi
force-pushed
the
i123
branch
2 times, most recently
from
159a41d
to
98cf504
Compare
cfergeau
reviewed
Oct 22, 2024
doc/usage.md
Outdated
| @@ -158,6 +157,20 @@ made to the copy-on-write image, and not to the backing file. Only the | |||
| modified data will use actual disk space. | |||
| A copy-on-write image can be created using `cp -c` or [clonefile(2)](http://www.manpagez.com/man/2/clonefile/). | |||
|
|
|||
| #### Cloud-init | |||
|
|
|||
| The `--device virtio-blk` option could also be used to supply an initial configuration to cloud-init through an disk image. | |||
There was a problem hiding this comment.
can also be used... a disk image
doc/usage.md
Outdated
| It is also possible to add further configurations by using the network-config and vendor-data files. | ||
| See https://cloudinit.readthedocs.io/en/latest/reference/datasources/nocloud.html#runtime-configurations for more details. | ||
|
|
||
| To create the ISO image you could use the following command within a folder containing the user-data and meta-data files |
There was a problem hiding this comment.
I'd use "can" here as well.
doc/usage.md
Outdated
| @@ -170,6 +183,11 @@ This adds a virtio-blk device to the VM which will be backed by the raw image at | |||
| --device virtio-blk,path=/Users/virtuser/vfkit.img | |||
| ``` | |||
|
|
|||
| To also push the cloud-init configuration you can add an additional virtio-blk device backed by an image containing the cloud-init configuration files | |||
There was a problem hiding this comment.
"push" reads a bit odd here, maybe "provide" would work?
test/osprovider.go
Outdated
| } | ||
| if _, err := file.Seek(0, 0); err != nil { | ||
| return "", err | ||
| } |
There was a problem hiding this comment.
is this header reading required? you do not seem to be making use of it?
test/osprovider.go
Outdated
| @@ -64,6 +121,16 @@ func NewPuipuiProvider() *PuiPuiProvider { | |||
| return &PuiPuiProvider{} | |||
| } | |||
|
|
|||
| type FedoraProvider struct { | |||
| vmlinuz string | |||
There was a problem hiding this comment.
diskImage or such would be easier to understand.
it adds the documentation to explain how to push cloud-init configuration by leveraging the virtio-blk device Signed-off-by: Luca Stocchi <[email protected]>
lstocchi
force-pushed
the
i123
branch
2 times, most recently
from
a7c8d05
to
41e879f
Compare
cfergeau
reviewed
Oct 23, 2024
it adds an e2e test which downloads fedora 40 and create a VM using it. Then mounts an ISO image containing the user-data and meta-data files needed by cloud-init to apply our configuration. The meta-data file is empty but the user-data file contains info about a new user that has to be added to the system. After the VM gets started it verifies that the user has been actually added by connecting using SSH. At the end, the VM is stopped. The test is not run on macOS12 as it does not support efi bootloader. Signed-off-by: Luca Stocchi <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the documentation to explain how to push cloud-init configuration as an ISO image by leveraging virtue-blk.
It also adds an e2e test to verify vfkit works with fedora and the cloud-init configuration is actually applied.
it closes #123