Add readonly option for storage devices #179
Conversation
The virtio-blk, nvme, and usb-mass-storage devices can use now `readonly` option to create a read only device. This exposes the exiting StorageConfig.ReadOnly field. Because this option is mostly useful to cdrom images, document the option only for usb-mass-storage.
|
Hi @nirs. Thanks for your PR. I'm waiting for a crc-org member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
We can create a read only device using the command line option, this change adds USBMassStorage.SetReadOnly() setting to allow crating a device programmatically.
Add test for converting command line options and formatting JSON.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks for the PR! |
The virtio-blk, nvme, and usb-mass-storage devices can use now
readonlyoption to create a read only device. This exposes the exiting StorageConfig.ReadOnly field.Because this option is mostly useful to cdrom images, document the option only for usb-mass-storage.