Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman: Install qemu-guest-agent in the bundle #595

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

cfergeau
Copy link
Contributor

@cfergeau cfergeau commented Nov 4, 2022

This will be needed by the timesync code (set the VM time automatically when the machine gets out of sleep).

It will be used to sync the time of the guest on macOS when the system
gets out of sleep.

A selinux policy change is needed to be allowed to use it over virtio-vsock.

To apply it (
https://relativkreativ.at/articles/how-to-compile-a-selinux-policy-package
)
checkmodule -M -m -o qemuga-vsock.mod qemuga-vsock.te
semodule_package -o qemuga-vsock.pp -m qemuga-vsock.mod
semodule -i qemuga-vsock.pp
@cfergeau cfergeau changed the base branch from master to podman November 4, 2022 09:05
@openshift-ci openshift-ci bot added the approved label Nov 4, 2022
# checkpolicy
/usr/bin/checkmodule -M -m -o qemuga-vsock.mod qemuga-vsock.te
# policycoreutils
/usr/bin/semodule_package -o qemuga-vsock.pp -m qemuga-vsock.mod
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cfergeau these commands need to run on the host can't we run it on the VM because our CI system is based on the RHEL8 host so I am wondering if those steps going to work as expected.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The needed packages are not available in the VM, this is why I run them on the host. We may need to install additional packages (the comments are the package names), but hopefully this will work fine on rhel8 when they are installed.

@praveenkumar
Copy link
Member

/retest

@openshift-ci
Copy link

openshift-ci bot commented Nov 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau, gbraad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 78db482 into crc-org:podman Nov 7, 2022
@praveenkumar
Copy link
Member

/test

@praveenkumar
Copy link
Member

/test e2e-snc

@cfergeau cfergeau deleted the podman-timesync branch December 14, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants