Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (daemon) : Add docker.internal entry to virtual network DNS config (#3784) #4601

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rohanKanojia
Copy link
Contributor

Description

Fixes: #3784

Port of containers/gvisor-tap-vsock#251 to add docker.internal. DNS record to CRC daemon virtual network config.

Relates to: PR containers/gvisor-tap-vsock#251

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Proposed changes

  • Move virtualNetwork config construction to a method so that it becomes testable
  • Add another entry to DNS zones for docker.internal.

Testing

I've only verified it using a unit test.

Contribution Checklist

  • I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Which platform have you tested the code changes on?
    • Linux
    • Windows
    • MacOS

Copy link

openshift-ci bot commented Feb 5, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rohanKanojia rohanKanojia marked this pull request as ready for review February 6, 2025 04:24
@openshift-ci openshift-ci bot requested review from anjannath and evidolob February 6, 2025 04:24
@praveenkumar
Copy link
Member

/assign @lstocchi @evidolob

},
virtualNetworkConfig.NAT[hostVirtualIP] = "127.0.0.1"
}
virtualNetworkConfig.GatewayVirtualIPs = []string{hostVirtualIP}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, I think GatewayVirtualIPs initialisation could be moved in to struct initialisation, it will slightly improve this code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your suggestion! I've moved it to struct initialization block.

@openshift-ci openshift-ci bot added the lgtm label Feb 27, 2025
Copy link

openshift-ci bot commented Feb 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evidolob

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

crc-org#3784)

Add `docker.internal` entry to virtual network config DNS records.

Signed-off-by: Rohan Kumar <[email protected]>
Copy link

openshift-ci bot commented Feb 27, 2025

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Feb 27, 2025

@rohanKanojia: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-crc 7cca461 link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Add .docker.internal entries to cmd/crc/cmd/daemon.go ?
4 participants