Try to create mount directory first before making it mutable #4585
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pkg/crc/machine/start.go
Outdated
| if !isHomeOrMnt { | ||
| // Try to create the mount directory and if it fails then | ||
| // make the file system mutable and again try to create the | ||
| // mount directory |
There was a problem hiding this comment.
I'd mention explicitly that if the directory already exists, then mkdir -p won't return an error.
This will remove logic to ignore /home or /mnt directory before make filesystem mutable. This will help in case other directories exist same way like /home or /mnt like `/Users` so we don't need to make filesystem mutable.
praveenkumar
force-pushed
the
ignore_file_permission
branch
from
88da767 to
bef755b
Compare
|
@praveenkumar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This will remove logic to ignore /home or /mnt directory before make filesystem mutable. This will help in case other directories exist same way like /home or /mnt like
/Usersso we don't need to make filesystem mutable.Description
Fixes: #N
Relates to: #N, PR #N, ...
Type of change
test, version modification, documentation, etc.)
Proposed changes
Testing
Contribution Checklist