windows-artifacts: run yq --inplace to windows-artifacts.yml #4175
Conversation
Looks like when yq is run on any yaml file it strip the blank like from the output so as part of parse mikefarah/yq#515 we use to parse this file to update the go version using the script in next commit so this commit just to make sure the formatting is right when it parsed with `yq` It is generated using `yq --inplace .github/workflows/windows-artifacts.yml`
in windows-artifacts.yml go version is mention under `build-installer` instead of `build` so this is missed during the go version update. This PR add it also so in future we don't miss.
|
@praveenkumar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianriobo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -18,4 +18,7 @@ for f in .github/workflows/*.yml; do | |||
| if [ $(yq eval '.jobs.build.strategy.matrix | has("go")' "$f") == "true" ]; then | |||
| yq eval --inplace ".jobs.build.strategy.matrix.go[0] = ${golang_base_version} | .jobs.build.strategy.matrix.go[0] style=\"single\"" "$f"; | |||
| fi | |||
| if [ $(yq eval '.jobs.build-installer.strategy.matrix | has("go")' "$f") == "true" ]; then | |||
There was a problem hiding this comment.
Ideally we'd be able to use something like .jobs.*.strategy.matrix instead of hardcoding the name of the jobs.
There was a problem hiding this comment.
If we are going to create a following for this I just realized the name for the images images/*/Dockerfile will not work for build-e2e and build-integration as I use the Containerfile as name for the file.
There was a problem hiding this comment.
An additional question how does dependabot fit in this upgrade process?
Looks like when yq is run on any yaml file it strip the blank like from
the output so as part of parse mikefarah/yq#515
we use to parse this file to update the go version using the script in
next commit so this commit just to make sure the formatting is right
when it parsed with
yqIt is generated using
yq --inplace .github/workflows/windows-artifacts.yml