Added date to CryptoUnit #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazzyghost
requested changes
Oct 7, 2020
There was a problem hiding this comment.
@lubotorok this fix is set as a TODO task in the develop branch. Nicely done!
What I would point out is that in the CryptoResponse class, during the parse handling, we need both the key and value. It would be efficient to iterate over the entry set rather than the key set ( which requires performing another operation to retrieve the values).
|
Changed to iteration over the entry set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tried to add a date attribute to your CryptoUnit class together with its filling from the AlphaVantage rest service. Seems to be working in my project.
PS: I am pushing something to GitHub for the first time so I hope this is a correct way.