Testcontainers: Don't always pull the OCI image before starting.

It is unfortunate in disconnected situations.
crate · Oct 9, 2024 · 5d8435a · 5d8435a
1 parent c6e42b9
commit 5d8435a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -6,6 +6,8 @@
   also checking `rowcount` for handling `INSERT OK, 0 rows` responses
 - MongoDB: Fixed BSON decoding of `{"$date": 1180690093000}` timestamps
   by updating to commons-codec 0.0.21.
+- Testcontainers: Don't always pull the OCI image before starting.
+  It is unfortunate in disconnected situations.
 
 ## 2024/10/01 v0.0.27
 - MongoDB: Updated to pymongo 4.9

diff --git a/cratedb_toolkit/testing/testcontainers/util.py b/cratedb_toolkit/testing/testcontainers/util.py
@@ -87,8 +87,9 @@ def start(self):
         containers = docker_client.client.api.containers(all=True, filters={"name": self._name})
 
         if not containers:
-            logger.info(f"Pulling image: {self.image}")
-            docker_client.client.images.pull(self.image)
+            if asbool(self._kwargs.get("pull", False)):
+                logger.info(f"Pulling image: {self.image}")
+                docker_client.client.images.pull(self.image)
             logger.info(f"Creating container from image: {self.image}")
             self._container = docker_client.run(
                 self.image,