Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing error context in error collection crashing sqlparse #96

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

surister
Copy link
Collaborator

Summary of the changes / Why this is an improvement

Fixes #66

Checklist

  • Link to issue this PR refers to (if applicable): Fixes #???

@cla-bot cla-bot bot added the cla-signed label Oct 14, 2024
@surister surister force-pushed the main branch 4 times, most recently from 6bccc7e to bf6db28 Compare October 14, 2024 15:08
@surister surister requested review from amotl and kneth October 14, 2024 15:23
Copy link

@kneth kneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments are suggestions, and they are no way blocking you from merging 😄

cratedb_sqlparse_js/cratedb_sqlparse/parser.js Outdated Show resolved Hide resolved
cratedb_sqlparse_js/cratedb_sqlparse/parser.js Outdated Show resolved Hide resolved
cratedb_sqlparse_js/cratedb_sqlparse/parser.js Outdated Show resolved Hide resolved
Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't have been able to provide such good suggestions about JavaScript like added by @kneth. Thanks a stack.

@surister
Copy link
Collaborator Author

Fixed dependency missmatches (dependabot Prs were merged earlier) and applied comments. Thanks!

@surister surister merged commit 56c9fca into crate:main Oct 16, 2024
6 checks passed
@surister surister deleted the main branch October 16, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing closing bracket leads to crash of js sql-parse
3 participants