Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readme, modify setup_grammar.py to show proper usage. #7

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

surister
Copy link
Collaborator

Summary of the changes / Why this is an improvement

Checklist

  • Link to issue this PR refers to (if applicable):
  • CLA is signed

@surister surister requested a review from amotl April 16, 2024 14:29
Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Using active voice would be cool for docs and prose on future occasions. Here, this can also happen on a subsequent iteration.

README.md Outdated Show resolved Hide resolved
@surister
Copy link
Collaborator Author

Thanks. Using active voice would be cool for docs and prose on future occasions. Here, this can also happen on a subsequent iteration.

Thanks, I re-pushed a new version, hopefully it's better now.

@surister surister merged commit b1abdfa into crate:master Apr 16, 2024
@amotl
Copy link
Member

amotl commented Apr 16, 2024

Excellent. 💯

assert wordcount("we") == 0

Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants