Python: Set python version to just >=3.8 #49
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes / Why this is an improvement
cratedb-sqlparse requires Python
<3.13,>=3.8
If you create a new environment with poetry for example, the default version will be
^{yoursystempythonversion}
, for my system which uses 3.12 is^3.12
, this translates to>=3.13,<4.0
.Making it incompatible if I don't change my local version.
This is the error:
I checked how other popular packages define versions and most just do:
>=3.8
or>=3.9
they don't bother with upper bounds, settings this fixes my issue.example: https://github.com/psf/requests/blob/0e322af87745eff34caffe4df68456ebc20d9068/setup.py#L97C5-L97C28
Checklist