Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Set python version to just >=3.8 #49

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

surister
Copy link
Collaborator

@surister surister commented Jul 2, 2024

Summary of the changes / Why this is an improvement

cratedb-sqlparse requires Python <3.13,>=3.8

If you create a new environment with poetry for example, the default version will be ^{yoursystempythonversion}, for my system which uses 3.12 is ^3.12, this translates to >=3.13,<4.0.

Making it incompatible if I don't change my local version.

This is the error:
image

I checked how other popular packages define versions and most just do: >=3.8 or >=3.9 they don't bother with upper bounds, settings this fixes my issue.

example: https://github.com/psf/requests/blob/0e322af87745eff34caffe4df68456ebc20d9068/setup.py#L97C5-L97C28

Checklist

  • Link to issue this PR refers to (if applicable):
  • CLA is signed

@surister surister requested a review from amotl July 2, 2024 13:27
@surister surister merged commit 0186275 into crate:main Jul 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants