Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add valid pypi versioningit's version scheme #47

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

surister
Copy link
Collaborator

@surister surister commented Jul 2, 2024

Summary of the changes / Why this is an improvement

Currently the generated version is not accepted by pypi

From https://peps.python.org/pep-0440/:

Local version identifiers SHOULD NOT be used when publishing upstream projects to a public index server, but MAY be used to identify private builds created directly from the project source. Local version identifiers

Checklist

  • Link to issue this PR refers to (if applicable):
  • CLA is signed

@surister surister merged commit d283e1d into crate:main Jul 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant