Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve heuristics of assigning an error to its statement #34

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

surister
Copy link
Collaborator

@surister surister commented Jun 7, 2024

Summary of the changes / Why this is an improvement

Found an fixed an edge case where error was not being assigned to statement.

Checklist

  • Link to issue this PR refers to (if applicable):
  • CLA is signed

@surister surister requested a review from amotl June 7, 2024 18:01
@surister
Copy link
Collaborator Author

surister commented Jun 7, 2024

Will fix lint later

cratedb_sqlparse_py/cratedb_sqlparse/parser.py Outdated Show resolved Hide resolved
@surister surister force-pushed the exception_edge_case branch from af56473 to f6ad0ac Compare June 10, 2024 09:53
@surister surister merged commit 04bda35 into crate:main Jun 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants