Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaScript: Fix package entrypoint. Naming things. #24

Merged
merged 2 commits into from
May 30, 2024
Merged

JavaScript: Fix package entrypoint. Naming things. #24

merged 2 commits into from
May 30, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented May 30, 2024

About

  • The package intends to be published as @cratedb/cratedb-sqlparse.
  • The package entrypoint was wrong, so npm run build croaked.

@amotl amotl requested review from surister and alexdametto May 30, 2024 08:06
@amotl
JavaScript: Naming things
bd6cda7 
The package intends to be published as `@cratedb/cratedb-sqlparse`.
@amotl amotl force-pushed the amo/js-naming-things branch from 77a3ef4 to bd6cda7 Compare May 30, 2024 08:08
@amotl amotl mentioned this pull request May 30, 2024
Closed
alexdametto
alexdametto approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@alexdametto alexdametto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment on the name in vite.config.js, that could help with future re-naming (hoping they won't happen), but I am fine with this also.

cratedb_sqlparse_js/vite.config.js Outdated Show resolved Hide resolved
@amotl amotl merged commit 5b4b197 into main May 30, 2024
7 checks passed
@amotl amotl deleted the amo/js-naming-things branch May 30, 2024 08:35
@amotl amotl mentioned this pull request May 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexdametto alexdametto alexdametto approved these changes

@surister surister Awaiting requested review from surister

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amotl @alexdametto