Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore samples with different values with same timestamp on ingest #164

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

proddata
Copy link
Member

@proddata proddata commented Jul 31, 2024

Summary of the changes / Why this is an improvement

Considering that Prometheus doesn't allow samples with same timestamp and different values and enforcing this more strictly with newer version, just adding a ON CONFLICT DO NOTHING should be sufficient.

Checklist

@proddata proddata force-pushed the proddata/pk-conflict-behaviour branch 3 times, most recently from 6f93e3b to 652aa95 Compare August 5, 2024 08:57
@proddata proddata changed the title Add option to define primary key conflict behaviour Ignore samples with different values with same timestamp on ingest Aug 5, 2024
@proddata proddata requested review from amotl and surister August 5, 2024 08:58
Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a stack for this!

CHANGES.rst Outdated Show resolved Hide resolved
crate.go Show resolved Hide resolved
@proddata proddata force-pushed the proddata/pk-conflict-behaviour branch from 652aa95 to 8b3633e Compare August 7, 2024 06:54
Copy link

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @proddata !
Makes sense to resolve the issue like this, since we don't have the info to choose if we overwrite or not.

crate.go Outdated Show resolved Hide resolved
@proddata proddata force-pushed the proddata/pk-conflict-behaviour branch from 8b3633e to 6789176 Compare August 19, 2024 07:21
@proddata proddata force-pushed the proddata/pk-conflict-behaviour branch from 6789176 to 31bb571 Compare August 19, 2024 07:36
@proddata proddata merged commit 848e714 into main Aug 19, 2024
8 checks passed
@proddata proddata deleted the proddata/pk-conflict-behaviour branch August 19, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants