Add integration tests #109
Conversation
amotl
force-pushed
the
amo/integration-tests
branch
2 times, most recently
from
7907c13 to
02229d9
Compare
Not only the write path was broken due to interface changes, the read path also did not work.
amotl
force-pushed
the
amo/integration-tests
branch
from
02229d9 to
7d34da2
Compare
amotl
force-pushed
the
amo/integration-tests
branch
from
9c5be73 to
6b26e53
Compare
amotl
force-pushed
the
amo/integration-tests
branch
from
6b26e53 to
c87665d
Compare
| prometheus-api-client<0.6 | ||
| pytest<8 | ||
| pytest-env<2 | ||
| requests<3 |
There was a problem hiding this comment.
Should we also add a corresponding section to the dependabot config, to keep the test requirements up to date?
There was a problem hiding this comment.
That was clearly an oversight, thank you so much for spotting that flaw. Fixed with f43b3d4.
|
|
||
| Run integration tests:: | ||
|
|
||
| pytest |
There was a problem hiding this comment.
Should mention to run pip3 install --upgrade -r requirements-test.txt before?
There was a problem hiding this comment.
Absolutely, thank you again. I've expanded this a bit more to also educate readers about how to set up the Python sandbox (virtualenv). See 87f8e11.
There was a problem hiding this comment.
May I ask you to review both spots once more and acknowledge the PR again if you agree with the updates? Thanks!
|
Thanks for the reviews. Merging the dependency update patches enumerated above feels so confident now -- good that we finally gained such a test layer for this piece of software. |
About
As we learned through GH-88, the unit tests are not sufficient to validate the code base thoroughly. This patch intends to bring in integration tests with real instances of Prometheus, CrateDB, and CrateDB Prometheus Adapter, effectively adding end-to-end test cases, so that corresponding required adjustments/fixes like GH-96 or 2043818 will not be missed in the future.
Details
The patch also includes the commit 2043818, which is actual a bugfix accompanying GH-96. It has been discovered while adding the test cases validating the read path.
Screenshot
Outlook
The integration tests added on behalf of this patch will ensure that bringing in those upcoming dependency update patches will not break the application again.
/cc @matriv, @seut, @ckurze, @wierdvanderhaar