-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exploratory data analysis with PyCaret #311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a few more suggestions, I am approving this patch. Thanks again, Marija!
However, I did not do a thorough review of the notebook content, shape, and prose. Let's also have @ckurze a final voice on it if he wants to. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for extending the notebook! Very good work. I added a few notes about typos.
Co-authored-by: Andreas Motl <[email protected]>
Co-authored-by: Andreas Motl <[email protected]>
Co-authored-by: ckurze <[email protected]>
Co-authored-by: ckurze <[email protected]>
Co-authored-by: ckurze <[email protected]>
Co-authored-by: ckurze <[email protected]>
0a904a3
to
1805a48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed dependency to SQLAlchemy/Crate, and removed " at the end of requirements file.
Co-authored-by: ckurze <[email protected]>
Co-authored-by: ckurze <[email protected]>
Can someone merge this PR? For me, the merge is blocked. |
The reason is this: @ckurze needs to acknowledge this PR, because he requested changes on it. For this to optimally happen, you would have needed to re-request a review from him. I've just invoked the corresponding action for you.
Sure. Thanks! Can I ask you to squash your commits beforehand? |
I don't think it is a good idea to add yet another piece to this PR, now that we have concluded the review process on the previous one. Please commandeer it into a different PR. Thanks! |
Is the review process really completed? Merging was still blocked. The new piece is just a continuation of the previous one but put in a separate notebook for organizational reasons (easier for subsequent video creation.) |
I think after resolving @ckurze's comments, it was just a technicality to acknowledge the review. Maybe he is not available now, so I also could have merged the PR after squashing the commit. I can't do the merge now after you added more content, apologies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes needed in Readme.md and the timeseries decomposition notebook.
This notebook explores how to access timeseries data from CrateDB via SQL, | ||
and do the exploratory data analysis with PyCaret. | ||
|
||
It also shows how you can generate various plots and charts for EDA, helping you understand data distributions, relationships between variables, and identify patterns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Time Series decomposition should be added to the readme file as well, incl. link to Colab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last commit updates README file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
@marijaselakovic Just restored the branch, can we harmonize the file names, please? I'd prefer if (similar to the folder name), timeseries is just one word, pls. see screenshot. Thank you! |
Hi, thanks for your contribution, and congratulations for merging. It is fine when a PR includes multiple commits which have a semantic meaning, but not like this: In a situation like this, you usually squash the commits into one or multiple groups of commits before integrating them into the main branch. I've just amended the history and force-pushed to -- https://github.com/crate/cratedb-examples/commits/main/ |
Please branch off from a freshly fetched |
Summary of the changes / Why this is an improvement
Checklist