Reflect node.max_local_storage_nodes setting removal #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaurzhanSakhariev
force-pushed
the
baur/bwc-max-local-storage-nodes
branch
from
71d3e2b to
1366cad
Compare
|
Hi @mfussenegger, could you please take a look? Cannot run nightly locally on macOS due to mfussenegger/cr8#311 - and if I try to use |
| @@ -226,7 +224,6 @@ def upgrade_node(self, old_node, new_version): | |||
| return new_node | |||
|
|
|||
| def setUp(self): | |||
| self._path_data = self.mkdtemp() | |||
There was a problem hiding this comment.
Looks like this property is accessed in some other test cases:
tests/restart/test_blob.py
65: filepath = Path(self._path_data).glob(f'**/{digest}')
tests/bwc/test_upgrade.py
382: data_path_incl_cluster_id = os.path.join(self._path_data, self.CLUSTER_ID)
385: target_path_nodes = os.path.join(self._path_data, 'nodes')
There was a problem hiding this comment.
thx for the hint!
There was a problem hiding this comment.
I now keep this variable, just moved it below to the new_node. checked locally 4.8->nightly by replacing nightly to branch:master
BaurzhanSakhariev
force-pushed
the
baur/bwc-max-local-storage-nodes
branch
from
1366cad to
9834a19
Compare
BaurzhanSakhariev
force-pushed
the
baur/bwc-max-local-storage-nodes
branch
from
9834a19 to
8417a0e
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to crate/crate#12463
Fixes https://github.com/crate/crate-alerts/issues/249
Checklist